Refactor interaction between Pass and PassRunner (#5093)

Previously only WalkerPasses had access to the `getPassRunner` and
`getPassOptions` methods. Move those methods to `Pass` so all passes can use
them. As a result, the `PassRunner` passed to `Pass::run` and
`Pass::runOnFunction` is no longer necessary, so remove it.

Also update `Pass::create` to return a unique_ptr, which is more efficient than
having it return a raw pointer only to have the `PassRunner` wrap that raw
pointer in a `unique_ptr`.

Delete the unused template `PassRunner::getLast()`, which looks like it was
intended to enable retrieving previous analyses and has been in the code base
since 2015 but is not implemented anywhere.

1 files changed, 3 insertions, 2 deletions

diff --git a/src/passes/test_passes.cpp b/src/passes/test_passes.cpp
index 4ea5b8696..54c4818e8 100644
--- a/src/passes/test_passes.cpp
+++ b/src/passes/test_passes.cpp
@@ -31,12 +31,13 @@ namespace {
 // Pass to test EHUtil::handleBlockNestedPops function
 struct CatchPopFixup : public WalkerPass<PostWalker<CatchPopFixup>> {
   bool isFunctionParallel() override { return true; }
-  Pass* create() override { return new CatchPopFixup; }
+  std::unique_ptr<Pass> create() override {
+    return std::make_unique<CatchPopFixup>();
+  }
 
   void doWalkFunction(Function* func) {
     EHUtils::handleBlockNestedPops(func, *getModule());
   }
-  void run(PassRunner* runner, Module* module) override {}
 };
 
 } // anonymous namespace