diff options
author | Alon Zakai <alonzakai@gmail.com> | 2018-12-14 17:27:29 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-14 17:27:29 -0800 |
commit | 6cc598496a62ff4dbdb680b400ca26a9b1059e7c (patch) | |
tree | 7ba5891124f64741c9314cfd20c4987229cd0889 /src/tools/asm2wasm.cpp | |
parent | e8f5842d4a58a94b8a485a7e63dd8657d88eb805 (diff) | |
download | binaryen-6cc598496a62ff4dbdb680b400ca26a9b1059e7c.tar.gz binaryen-6cc598496a62ff4dbdb680b400ca26a9b1059e7c.tar.bz2 binaryen-6cc598496a62ff4dbdb680b400ca26a9b1059e7c.zip |
Minimal JS legalization (#1824)
Even when we don't want to fully legalize code for JS, we should still legalize things that only JS cares about. In particular, dynCall_* methods are used from JS to call into the wasm table, and if they exist they are only for JS, so we should only legalize them.
The use case motivating this is that in dynamic linking you may want to disable legalization, so that wasm=>wasm module calls are fast even with i64s, but you do still need dynCalls to be legalized even in that case, otherwise an invoke with an i64 parameter would fail.
Diffstat (limited to 'src/tools/asm2wasm.cpp')
-rw-r--r-- | src/tools/asm2wasm.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/asm2wasm.cpp b/src/tools/asm2wasm.cpp index a001c08a6..4907033e5 100644 --- a/src/tools/asm2wasm.cpp +++ b/src/tools/asm2wasm.cpp @@ -96,7 +96,7 @@ int main(int argc, const char *argv[]) { [&wasmOnly](Options *o, const std::string& ) { wasmOnly = true; }) - .add("--no-legalize-javascript-ffi", "-nj", "Do not legalize (i64->i32, f32->f64) the imports and exports for interfacing with JS", Options::Arguments::Zero, + .add("--no-legalize-javascript-ffi", "-nj", "Do not fully legalize (i64->i32, f32->f64) the imports and exports for interfacing with JS", Options::Arguments::Zero, [&legalizeJavaScriptFFI](Options *o, const std::string& ) { legalizeJavaScriptFFI = false; }) |