diff options
author | Sam Clegg <sbc@chromium.org> | 2022-05-31 07:04:51 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-31 07:04:51 -0700 |
commit | 46282a482ec81e8d379b4e9b3ee50f66dd0ac5e5 (patch) | |
tree | 2619fc5ca0b32b60beea064944fe5b5420d8eadc /src/tools/wasm-emscripten-finalize.cpp | |
parent | 838de5c4f374396a15d5700ebb51c3e0a89b5840 (diff) | |
download | binaryen-46282a482ec81e8d379b4e9b3ee50f66dd0ac5e5.tar.gz binaryen-46282a482ec81e8d379b4e9b3ee50f66dd0ac5e5.tar.bz2 binaryen-46282a482ec81e8d379b4e9b3ee50f66dd0ac5e5.zip |
Remove renameMainArgcArgv from wasm-emscripten-finalize (#4700)
This part to finalize is currently not used and was added in preparation
for https://reviews.llvm.org/D75277.
However, the better solution to dealing with this alternative name for
main is on the emscripten side. The main reason for this is that
doing the rename here in binaryen would require finalize to always
re-write the binary, which is expensive.
Diffstat (limited to 'src/tools/wasm-emscripten-finalize.cpp')
-rw-r--r-- | src/tools/wasm-emscripten-finalize.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/tools/wasm-emscripten-finalize.cpp b/src/tools/wasm-emscripten-finalize.cpp index 8fdc203a9..b4e27ca5c 100644 --- a/src/tools/wasm-emscripten-finalize.cpp +++ b/src/tools/wasm-emscripten-finalize.cpp @@ -266,12 +266,6 @@ int main(int argc, const char* argv[]) { generator.onlyI64DynCalls = onlyI64DynCalls; generator.noDynCalls = noDynCalls; - if (!standaloneWasm) { - // This is also not needed in standalone mode since standalone mode uses - // crt1.c to invoke the main and is aware of __main_argc_argv mangling. - generator.renameMainArgcArgv(); - } - PassRunner passRunner(&wasm, options.passOptions); passRunner.setDebug(options.debug); passRunner.setDebugInfo(debugInfo); |