Do not optimize public types (#5347)

Do not optimize or modify public heap types in any way. Public heap types
include the types of imported or exported functions, tables, globals, etc. This
is important to maintain the public interface of a module and ensure it can
still link interact as intended with the outside world.

Also add validation error if we find any nontrivial public types that are not
the types of imported or exported functions. This error is meant to help the
user ensure that type optimizations are not silently inhibited. In the future,
we may want to add options to silence this error or downgrade it to a warning.

This commit only updates the type updating machinery to avoid updating public
types. It does not update any optimization passes accordingly. Since we avoid
modifying public signature types already, this is not expected to break
anything, but in the future once we have function subtyping or if we make the
error optional, we may have to update some of our optimization passes.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/tools/wasm-opt.cpp b/src/tools/wasm-opt.cpp
index 8f958f164..0d279dc08 100644
--- a/src/tools/wasm-opt.cpp
+++ b/src/tools/wasm-opt.cpp
@@ -295,7 +295,7 @@ int main(int argc, const char* argv[]) {
     }
 
     if (options.passOptions.validate) {
-      if (!WasmValidator().validate(wasm)) {
+      if (!WasmValidator().validate(wasm, options.passOptions)) {
         exitOnInvalidWasm("error validating input");
       }
     }
@@ -309,7 +309,7 @@ int main(int argc, const char* argv[]) {
     reader.setAllowOOB(fuzzOOB);
     reader.build();
     if (options.passOptions.validate) {
-      if (!WasmValidator().validate(wasm)) {
+      if (!WasmValidator().validate(wasm, options.passOptions)) {
         std::cout << wasm << '\n';
         Fatal() << "error after translate-to-fuzz";
       }
@@ -368,7 +368,7 @@ int main(int argc, const char* argv[]) {
     auto runPasses = [&]() {
       options.runPasses(wasm);
       if (options.passOptions.validate) {
-        bool valid = WasmValidator().validate(wasm);
+        bool valid = WasmValidator().validate(wasm, options.passOptions);
         if (!valid) {
           exitOnInvalidWasm("error after opts");
         }