diff options
| author | Thomas Lively <tlively@google.com> | 2022-09-30 18:17:45 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-30 23:17:45 +0000 |
| commit | 2055ea3fd0391c1abb92cdec54f32274dc7fd971 (patch) | |
| tree | 2d9ccaae076b065373b1507d75bc3886232363ec /src/tools/wasm-split/wasm-split.cpp | |
| parent | 62d056f889d4b94562a104e2fcad318857550d5b (diff) | |
| download | binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.gz binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.tar.bz2 binaryen-2055ea3fd0391c1abb92cdec54f32274dc7fd971.zip | |
Refactor interaction between Pass and PassRunner (#5093)
Previously only WalkerPasses had access to the `getPassRunner` and
`getPassOptions` methods. Move those methods to `Pass` so all passes can use
them. As a result, the `PassRunner` passed to `Pass::run` and
`Pass::runOnFunction` is no longer necessary, so remove it.
Also update `Pass::create` to return a unique_ptr, which is more efficient than
having it return a raw pointer only to have the `PassRunner` wrap that raw
pointer in a `unique_ptr`.
Delete the unused template `PassRunner::getLast()`, which looks like it was
intended to enable retrieving previous analyses and has been in the code base
since 2015 but is not implemented anywhere.
Diffstat (limited to 'src/tools/wasm-split/wasm-split.cpp')
| -rw-r--r-- | src/tools/wasm-split/wasm-split.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/tools/wasm-split/wasm-split.cpp b/src/tools/wasm-split/wasm-split.cpp index ec1f5555c..49a15e934 100644 --- a/src/tools/wasm-split/wasm-split.cpp +++ b/src/tools/wasm-split/wasm-split.cpp @@ -110,7 +110,6 @@ void instrumentModule(const WasmSplitOptions& options) { } uint64_t moduleHash = hashFile(options.inputFiles[0]); - PassRunner runner(&wasm, options.passOptions); InstrumenterConfig config; if (options.importNamespace.size()) { config.importNamespace = options.importNamespace; @@ -120,7 +119,10 @@ void instrumentModule(const WasmSplitOptions& options) { } config.storageKind = options.storageKind; config.profileExport = options.profileExport; - Instrumenter(config, moduleHash).run(&runner, &wasm); + + PassRunner runner(&wasm, options.passOptions); + runner.add(std::make_unique<Instrumenter>(config, moduleHash)); + runner.run(); adjustTableSize(wasm, options.initialTableSize); |