diff options
| author | Paweł Bylica <chfast@gmail.com> | 2019-01-10 17:23:08 +0100 |
|---|---|---|
| committer | Alon Zakai <alonzakai@gmail.com> | 2019-01-10 08:23:08 -0800 |
| commit | 51a481f6ed9e39b284421778b63b265eca6c1b58 (patch) | |
| tree | cf55edd7cc08dddc18900fe4f8badb4b39dbf837 /src/tools | |
| parent | e71506165996f7a12cd54361761bc88c7f883cd2 (diff) | |
| download | binaryen-51a481f6ed9e39b284421778b63b265eca6c1b58.tar.gz binaryen-51a481f6ed9e39b284421778b63b265eca6c1b58.tar.bz2 binaryen-51a481f6ed9e39b284421778b63b265eca6c1b58.zip | |
Require unique_ptr to Module::addFunctionType() (#1672)
This fixes the memory leak in WasmBinaryBuilder::readSignatures() caused probably the exception thrown there before the FunctionType object is safe.
This also makes it clear that the Module becomes the owner of the FunctionType objects.
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/wasm-merge.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/wasm-merge.cpp b/src/tools/wasm-merge.cpp index e9ac6d649..6dd522d16 100644 --- a/src/tools/wasm-merge.cpp +++ b/src/tools/wasm-merge.cpp @@ -447,7 +447,7 @@ struct InputMergeable : public ExpressionStackWalker<InputMergeable, Visitor<Inp // copy in the data for (auto& curr : wasm.functionTypes) { - outputMergeable.wasm.addFunctionType(curr.release()); + outputMergeable.wasm.addFunctionType(std::move(curr)); } for (auto& curr : wasm.globals) { if (curr->imported()) { |