[wasm-builder] Construct module elements as unique_ptrs (#3391)

When Functions, Globals, Events, and Exports are added to a module, if they are
not already in std::unique_ptrs, they are wrapped in a new std::unique_ptr owned
by the Module. This adds an extra layer of indirection when accessing those
elements that can be avoided by allocating those elements as std::unique_ptrs.
This PR updates wasm-builder to allocate module elements via std::make_unique
rather than `new`. In the future, we should remove the raw pointer versions of
Module::add* to encourage using std::unique_ptrs more broadly.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/wasm-binary.h b/src/wasm-binary.h
index 205a9b447..ef3f9c9d1 100644
--- a/src/wasm-binary.h
+++ b/src/wasm-binary.h
@@ -1362,7 +1362,7 @@ public:
   Index endOfFunction = -1;
 
   // we store globals here before wasm.addGlobal after we know their names
-  std::vector<Global*> globals;
+  std::vector<std::unique_ptr<Global>> globals;
   // we store global imports here before wasm.addGlobalImport after we know
   // their names
   std::vector<Global*> globalImports;