diff options
author | Alon Zakai <azakai@google.com> | 2021-01-27 23:31:09 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-27 15:31:09 -0800 |
commit | a5aa66c52e0b92597a3b90cf34ccc3b7dee775d0 (patch) | |
tree | 653b71fa0c6be8c84ea37f3045ab23b19a09ccd2 /src/wasm-builder.h | |
parent | 1b950a1c4eb7b1a0a1d71c7e68e223fe57fdff66 (diff) | |
download | binaryen-a5aa66c52e0b92597a3b90cf34ccc3b7dee775d0.tar.gz binaryen-a5aa66c52e0b92597a3b90cf34ccc3b7dee775d0.tar.bz2 binaryen-a5aa66c52e0b92597a3b90cf34ccc3b7dee775d0.zip |
Remove test suite's assumption of minify_check roundtripping perfectly (#3524)
minify_check checks that we can print and read minified wast. The test
also, however, assumed that we round-trip such things perfectly. That's
never been true, and only by chance did this go unnoticed until now,
in #3523
The specific issue happening there is that we create a block without a
name. Then we write that as text, then read it. When we read it, we give
all such blocks a name (and we rely on optimizations to remove it later
when possible - this avoids optimizing in the parser). The extra name
looks like a bug to minify_check.
Diffstat (limited to 'src/wasm-builder.h')
0 files changed, 0 insertions, 0 deletions