Change from storing Signature to HeapType on CallIndirect (#4352)

With nominal function types, this change makes it so that we preserve the
identity of the function type used with call_indirect instructions rather than
recreating a function heap type, which may or may not be the same as the
originally parsed heap type, from the function signature during module writing.

This will simplify the type system implementation by removing the need to store
a "canonical" nominal heap type for each unique signature. We previously
depended on those canonical types to avoid creating multiple duplicate function
types during module writing, but now we aren't creating any new function types
at all.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/wasm-interpreter.h b/src/wasm-interpreter.h
index 7eb13c002..caccef654 100644
--- a/src/wasm-interpreter.h
+++ b/src/wasm-interpreter.h
@@ -2313,7 +2313,7 @@ public:
     virtual Literals callImport(Function* import, LiteralList& arguments) = 0;
     virtual Literals callTable(Name tableName,
                                Index index,
-                               Signature sig,
+                               HeapType sig,
                                LiteralList& arguments,
                                Type result,
                                SubType& instance) = 0;
@@ -2770,7 +2770,7 @@ private:
 
       auto info = instance.getTableInterfaceInfo(curr->table);
       Flow ret = info.interface->callTable(
-        info.name, index, curr->sig, arguments, type, *instance.self());
+        info.name, index, curr->heapType, arguments, type, *instance.self());
 
       // TODO: make this a proper tail call (return first)
       if (curr->isReturn) {