summaryrefslogtreecommitdiff
path: root/src/wasm-interpreter.h
diff options
context:
space:
mode:
authorHeejin Ahn <aheejin@gmail.com>2021-01-15 18:48:00 +0900
committerGitHub <noreply@github.com>2021-01-15 18:48:00 +0900
commitbeccdf70258cd99ea25f10af13103e14dc243ffa (patch)
tree1081d7d350fbab7f901b917f2f082c8d351c3157 /src/wasm-interpreter.h
parentf18c18e01d03d6d293fe3d701408855bbcea58bd (diff)
downloadbinaryen-beccdf70258cd99ea25f10af13103e14dc243ffa.tar.gz
binaryen-beccdf70258cd99ea25f10af13103e14dc243ffa.tar.bz2
binaryen-beccdf70258cd99ea25f10af13103e14dc243ffa.zip
Basic EH instrucion support for the new spec (#3487)
This updates `try`-`catch`-`catch_all` and `rethrow` instructions to match the new spec. `delegate` is not included. Now `Try` contains not a single `catchBody` expression but a vector of catch bodies and events. This updates most existing routines, optimizations, and tests modulo the interpreter and the CFG traversal. Because the interpreter has not been updated yet, the EH spec test is temporarily disabled in check.py. Also, because the CFG traversal for EH is not yet updated, several EH tests in `rse_all-features.wast`, which uses CFG traversal, are temporarily commented out. Also added a few more tests in existing EH test functions in test/passes. In the previous spec, `catch` was catching all exceptions so it was assumed that anything `try` body throws is caught by its `catch`, but now we can assume the same only if there is a `catch_all`. Newly added tests test cases when there is a `catch_all` and cases there are only `catch`es separately.
Diffstat (limited to 'src/wasm-interpreter.h')
-rw-r--r--src/wasm-interpreter.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/wasm-interpreter.h b/src/wasm-interpreter.h
index 243542836..2636b20f2 100644
--- a/src/wasm-interpreter.h
+++ b/src/wasm-interpreter.h
@@ -1347,7 +1347,10 @@ public:
WASM_UNREACHABLE("throw");
}
Flow visitRethrow(Rethrow* curr) {
+ // FIXME Update the implementation to match the new spec
NOTE_ENTER("Rethrow");
+ WASM_UNREACHABLE("unimp");
+ /*
Flow flow = visit(curr->exnref);
if (flow.breaking()) {
return flow;
@@ -1358,6 +1361,7 @@ public:
}
throwException(value);
WASM_UNREACHABLE("rethrow");
+ */
}
Flow visitBrOnExn(BrOnExn* curr) {
NOTE_ENTER("BrOnExn");
@@ -2943,6 +2947,9 @@ private:
return {};
}
Flow visitTry(Try* curr) {
+ // FIXME Update the implementation to match the new spec
+ WASM_UNREACHABLE("unimp");
+ /*
NOTE_ENTER("Try");
try {
return this->visit(curr->body);
@@ -2950,6 +2957,7 @@ private:
instance.multiValues.push_back(e.exn);
return this->visit(curr->catchBody);
}
+ */
}
Flow visitPop(Pop* curr) {
NOTE_ENTER("Pop");