diff options
| author | Roberto Lublinerman <rluble@google.com> | 2024-03-19 15:04:47 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-19 22:04:47 +0000 |
| commit | f9dc56913085eb7c2565047d87ca84b84a837518 (patch) | |
| tree | c6cb2c6163999c1bfb2e57ed8f400175476315cd /src/wasm-interpreter.h | |
| parent | 4ce9fb460b6a1161209904264bafec96abe911ac (diff) | |
| download | binaryen-f9dc56913085eb7c2565047d87ca84b84a837518.tar.gz binaryen-f9dc56913085eb7c2565047d87ca84b84a837518.tar.bz2 binaryen-f9dc56913085eb7c2565047d87ca84b84a837518.zip | |
[Strings] Avoid mishandling unicode in StringConcat (#6411)
Diffstat (limited to 'src/wasm-interpreter.h')
| -rw-r--r-- | src/wasm-interpreter.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/wasm-interpreter.h b/src/wasm-interpreter.h index af01865f4..36542e6ed 100644 --- a/src/wasm-interpreter.h +++ b/src/wasm-interpreter.h @@ -1959,6 +1959,11 @@ public: if (!leftData || !rightData) { trap("null ref"); } + // This is only correct if all the bytes in the left operand correspond + // to single unicode code points. + if (hasNonAsciiUpTo(leftData->values)) { + return Flow(NONCONSTANT_FLOW); + } Literals contents; contents.reserve(leftData->values.size() + rightData->values.size()); |