diff options
author | Thomas Lively <tlively@google.com> | 2024-09-16 14:12:13 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-16 14:12:13 -0700 |
commit | 2a4096512d514b2319ff1c9360f0fbc9ecc94e5d (patch) | |
tree | fe5953fcaaa673ec2f106fe7653d83294143db90 /src/wasm-stack.h | |
parent | 4913080cd040c0e0a1607ed73ac13bbbafe3a05d (diff) | |
download | binaryen-2a4096512d514b2319ff1c9360f0fbc9ecc94e5d.tar.gz binaryen-2a4096512d514b2319ff1c9360f0fbc9ecc94e5d.tar.bz2 binaryen-2a4096512d514b2319ff1c9360f0fbc9ecc94e5d.zip |
Remove open "ignorable public" array types (#6940)
There are a few heap types that are hard-coded to be considered public
and therefore allowed on module boundaries even in --closed-world mode,
specifically to support js-string-builtins. We previously considered
both open and closed (i.e. final) mutable i8 arrays to be public in this
manner, but js-string-builtins only uses the closed versions, so remove
the open versions.
This fixes a particular bug in which Unsubtyping optimized a private
array type to be equivalent to an ignorable public array type,
incorrectly changing the behavior of a cast, but it does not address the
larger problem of optimizations producing types that are equivalent to
public types. Add a TODO about that problem for now.
Fixes #6935.
Diffstat (limited to 'src/wasm-stack.h')
0 files changed, 0 insertions, 0 deletions