diff options
| author | Thomas Lively <tlively@google.com> | 2024-08-06 14:25:04 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-06 18:25:04 +0000 |
| commit | d5a5425c0c76cfc08711b81d6ec70c3a2879e405 (patch) | |
| tree | cb8f2dae76598416e833c1818438a46bf7666e19 /src/wasm-type.h | |
| parent | a985e16832f86cbc42eb6488e6f9fc2a9eff7dc7 (diff) | |
| download | binaryen-d5a5425c0c76cfc08711b81d6ec70c3a2879e405.tar.gz binaryen-d5a5425c0c76cfc08711b81d6ec70c3a2879e405.tar.bz2 binaryen-d5a5425c0c76cfc08711b81d6ec70c3a2879e405.zip | |
Restore isString type methods (#6815)
PR ##6803 proposed removing Type::isString and HeapType::isString in
favor of more explicit, verbose callsites. There was no consensus to
make this change, but it was accidentally committed as part of #6804.
Revert the accidental change, except for the useful, noncontroversial
parts, such as fixing the `isString` implementation and a few other
locations to correctly handle shared types.
Diffstat (limited to 'src/wasm-type.h')
| -rw-r--r-- | src/wasm-type.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/wasm-type.h b/src/wasm-type.h index 58655edc7..88590cc17 100644 --- a/src/wasm-type.h +++ b/src/wasm-type.h @@ -170,6 +170,7 @@ public: bool isSignature() const; bool isStruct() const; bool isArray() const; + bool isString() const; bool isDefaultable() const; Nullability getNullability() const; @@ -387,6 +388,7 @@ public: bool isContinuation() const { return getKind() == HeapTypeKind::Cont; } bool isStruct() const { return getKind() == HeapTypeKind::Struct; } bool isArray() const { return getKind() == HeapTypeKind::Array; } + bool isString() const { return isMaybeShared(HeapType::string); } bool isBottom() const; bool isOpen() const; bool isShared() const { return getShared() == Shared; } |