[GC] Update br_on_cast: the text format also no longer has a heap type (#3523)

As a result, we cannot handle a br_on_cast with an unreachable RTT. The
binary format solves the problem by ignoring unreachable code, and this makes
the text format do the same.

A nice benefit of this is that we can remove the castType extra field.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp
index 398ef9cb5..4a82c84a9 100644
--- a/src/wasm/wasm-binary.cpp
+++ b/src/wasm/wasm-binary.cpp
@@ -5835,7 +5835,7 @@ bool WasmBinaryBuilder::maybeVisitBrOnCast(Expression*& out, uint32_t code) {
     throwError("bad rtt for br_on_cast");
   }
   auto* ref = popNonVoidExpression();
-  out = Builder(wasm).makeBrOnCast(name, rtt->type.getHeapType(), ref, rtt);
+  out = Builder(wasm).makeBrOnCast(name, ref, rtt);
   return true;
 }