diff options
author | Alon Zakai <azakai@google.com> | 2021-12-16 09:39:17 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-12-16 09:39:17 -0800 |
commit | 62d83d5fcad015ce52f0f3122eab9df1c629cafb (patch) | |
tree | 894177e8addef43e42918afa486143925c644608 /src/wasm/wasm-binary.cpp | |
parent | 4905e74fff164d57aa1c5aaf7cb0f5c60ec635bc (diff) | |
download | binaryen-62d83d5fcad015ce52f0f3122eab9df1c629cafb.tar.gz binaryen-62d83d5fcad015ce52f0f3122eab9df1c629cafb.tar.bz2 binaryen-62d83d5fcad015ce52f0f3122eab9df1c629cafb.zip |
Add binary format parse checking for ref.as input type (#4389)
If that type is not valid then we cannot even create and finalize the node,
which means we'd hit an assertion inside finalize(), before we reach the
validator.
Fixes #4383
Diffstat (limited to 'src/wasm/wasm-binary.cpp')
-rw-r--r-- | src/wasm/wasm-binary.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp index bf29f948b..d8a3c2f74 100644 --- a/src/wasm/wasm-binary.cpp +++ b/src/wasm/wasm-binary.cpp @@ -6898,6 +6898,9 @@ void WasmBinaryBuilder::visitRefAs(RefAs* curr, uint8_t code) { WASM_UNREACHABLE("invalid code for ref.as_*"); } curr->value = popNonVoidExpression(); + if (!curr->value->type.isRef() && curr->value->type != Type::unreachable) { + throwError("bad input type for ref.as: " + curr->value->type.toString()); + } curr->finalize(); } |