RefFunc: Validate that the type is non-nullable, and avoid possible bugs in the builder (#3790)

The builder can receive a HeapType so that callers don't need to set non-nullability
themselves.

Not NFC as some of the callers were in fact still making it nullable.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp
index 3ff98187f..ed18cc0e4 100644
--- a/src/wasm/wasm-binary.cpp
+++ b/src/wasm/wasm-binary.cpp
@@ -2856,8 +2856,7 @@ void WasmBinaryBuilder::readElementSegments() {
         Index index = getU32LEB();
         auto sig = getSignatureByFunctionIndex(index);
         // Use a placeholder name for now
-        auto* refFunc = Builder(wasm).makeRefFunc(
-          Name::fromInt(index), Type(HeapType(sig), Nullable));
+        auto* refFunc = Builder(wasm).makeRefFunc(Name::fromInt(index), sig);
         functionRefs[index].push_back(refFunc);
         segmentData.push_back(refFunc);
       }