diff options
| author | Thomas Lively <tlively@google.com> | 2024-07-18 16:43:16 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-18 13:43:16 -0700 |
| commit | 84daeca1d7bfa805825771611d563920f3ebf846 (patch) | |
| tree | cb29dda1cb63ea0f35d68f9324904632e6bbc25e /src/wasm/wasm-binary.cpp | |
| parent | 848a28966e58f8a9788d2e5cf15790120e06cdf6 (diff) | |
| download | binaryen-84daeca1d7bfa805825771611d563920f3ebf846.tar.gz binaryen-84daeca1d7bfa805825771611d563920f3ebf846.tar.bz2 binaryen-84daeca1d7bfa805825771611d563920f3ebf846.zip | |
[NFC] Add HeapType::isMaybeShared(BasicHeapType) utility (#6773)
This abbreviates a common pattern where we first had to check whether a
heap type was basic, then if it was, get its unshared version and
compare it to some expected BasicHeapType.
Suggested in
https://github.com/WebAssembly/binaryen/pull/6771#discussion_r1683005495.
Diffstat (limited to 'src/wasm/wasm-binary.cpp')
| -rw-r--r-- | src/wasm/wasm-binary.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp index 20815b701..0a65fbadb 100644 --- a/src/wasm/wasm-binary.cpp +++ b/src/wasm/wasm-binary.cpp @@ -1521,7 +1521,7 @@ void WasmBinaryWriter::writeType(Type type) { // those more refined types. if (!wasm->features.hasGC()) { auto ht = type.getHeapType(); - if (ht.isBasic() && ht.getBasic(Unshared) == HeapType::string) { + if (ht.isMaybeShared(HeapType::string)) { // Do not overgeneralize stringref to anyref. We have tests that when a // stringref is expected, we actually get a stringref. If we see a // string, the stringref feature must be enabled. |