diff options
author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2020-09-11 13:34:01 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-09-11 13:34:01 -0700 |
commit | 8ec8a0bbfb039852b60f121fb23c439228b9fe36 (patch) | |
tree | 7987dcb2af2141dfc709cc8b761a69fd14f79798 /src/wasm/wasm-s-parser.cpp | |
parent | dbff242b3bc1fdaec15140cc48a537d7a497fb48 (diff) | |
download | binaryen-8ec8a0bbfb039852b60f121fb23c439228b9fe36.tar.gz binaryen-8ec8a0bbfb039852b60f121fb23c439228b9fe36.tar.bz2 binaryen-8ec8a0bbfb039852b60f121fb23c439228b9fe36.zip |
Update Pop text format to handle tuples (#3116)
Previously Pops were printed as ({type}.pop), and if the popped type was a
tuple, something like ((i32, i64).pop) would get printed. However, the parser
didn't support pops of anything besides single basic types.
This PR changes the text format to be (pop <type>*) and adds support for parsing
pops of tuples of basic types. The text format change is designed to make
parsing simpler. This change is necessary for writing Poppy IR tests (see #3059)
that contain break or return instructions that consume multiple values, since in
Poppy IR that requires tuple-typed pops.
Diffstat (limited to 'src/wasm/wasm-s-parser.cpp')
-rw-r--r-- | src/wasm/wasm-s-parser.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/wasm/wasm-s-parser.cpp b/src/wasm/wasm-s-parser.cpp index e4a33c034..97bfe55f9 100644 --- a/src/wasm/wasm-s-parser.cpp +++ b/src/wasm/wasm-s-parser.cpp @@ -1620,9 +1620,13 @@ Expression* SExpressionWasmBuilder::makeMemoryFill(Element& s) { return ret; } -Expression* SExpressionWasmBuilder::makePop(Type type) { +Expression* SExpressionWasmBuilder::makePop(Element& s) { auto ret = allocator.alloc<Pop>(); - ret->type = type; + std::vector<Type> types; + for (size_t i = 1; i < s.size(); ++i) { + types.push_back(stringToType(s[i]->str())); + } + ret->type = Type(types); ret->finalize(); return ret; } |