diff options
author | Alon Zakai <azakai@google.com> | 2021-02-06 00:46:37 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-02-05 16:46:37 -0800 |
commit | 51c8f2469f8fd05197b7694c65041b1567f2c6b5 (patch) | |
tree | 004877ed58384b8cccede06e872f4ed4c148670a /src/wasm/wasm-validator.cpp | |
parent | 9868c3636bf1309c23213dc8ef6de4c036d6c40b (diff) | |
download | binaryen-51c8f2469f8fd05197b7694c65041b1567f2c6b5.tar.gz binaryen-51c8f2469f8fd05197b7694c65041b1567f2c6b5.tar.bz2 binaryen-51c8f2469f8fd05197b7694c65041b1567f2c6b5.zip |
Use unordered maps of Name where possible (#3546)
Unordered maps will hash the pointer, while ordered ones will compare the
strings to find where to insert in the tree. I cannot confirm a speedup in time
from this, though others can, but I do see a consistent improvement of a
few % in perf stat results like number of instructions and cycles (and those
results have little noise). And it seems logical that this could be faster.
Diffstat (limited to 'src/wasm/wasm-validator.cpp')
-rw-r--r-- | src/wasm/wasm-validator.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wasm/wasm-validator.cpp b/src/wasm/wasm-validator.cpp index a9a69b244..fad78cefd 100644 --- a/src/wasm/wasm-validator.cpp +++ b/src/wasm/wasm-validator.cpp @@ -2465,7 +2465,7 @@ void FunctionValidator::visitFunction(Function* curr) { returnTypes.clear(); labelNames.clear(); // validate optional local names - std::set<Name> seen; + std::unordered_set<Name> seen; for (auto& pair : curr->localNames) { Name name = pair.second; shouldBeTrue(seen.insert(name).second, name, "local names must be unique"); |