diff options
| author | Thomas Lively <tlively@google.com> | 2022-11-22 11:59:22 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-22 09:59:22 -0800 |
| commit | 8e478839e825f4870d5205bca5e7f7cb33905da8 (patch) | |
| tree | a00fb7372fd018945e43ce6e7a1ab7317d92d897 /src/wasm/wasm-validator.cpp | |
| parent | 310a4e9118ccc14f42c6a2198104bf9b8358e48a (diff) | |
| download | binaryen-8e478839e825f4870d5205bca5e7f7cb33905da8.tar.gz binaryen-8e478839e825f4870d5205bca5e7f7cb33905da8.tar.bz2 binaryen-8e478839e825f4870d5205bca5e7f7cb33905da8.zip | |
[NFC] Expand comment about validating function type features (#5286)
This addresses feedback missed in #5279.
Diffstat (limited to 'src/wasm/wasm-validator.cpp')
| -rw-r--r-- | src/wasm/wasm-validator.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/wasm/wasm-validator.cpp b/src/wasm/wasm-validator.cpp index 37fbebef9..393d28c1e 100644 --- a/src/wasm/wasm-validator.cpp +++ b/src/wasm/wasm-validator.cpp @@ -2903,7 +2903,9 @@ void FunctionValidator::visitFunction(Function* curr) { "Multivalue function results (multivalue is not enabled)"); } FeatureSet features; - // Check for things like having a rec group with GC enabled. + // Check for things like having a rec group with GC enabled. The type we're + // checking is a reference type even if this an MVP function type, so ignore + // the reference types feature here. features |= (Type(curr->type, Nullable).getFeatures() & ~FeatureSet::ReferenceTypes); for (const auto& param : curr->getParams()) { |