diff options
| author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2021-05-18 15:58:31 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-18 15:58:31 -0700 |
| commit | 92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b (patch) | |
| tree | 988bdc1753ba73f41b7c2c5613170fa638a1e5f9 /src/wasm/wasm-validator.cpp | |
| parent | f8bb9c228446998882edea012bf9fa3004262504 (diff) | |
| download | binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.gz binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.bz2 binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.zip | |
Remove Type ordering (#3793)
As found in #3682, the current implementation of type ordering is not correct,
and although the immediate issue would be easy to fix, I don't think the current
intended comparison algorithm is correct in the first place. Rather than try to
switch to using a correct algorithm (which I am not sure I know how to
implement, although I have an idea) this PR removes Type ordering entirely. In
places that used Type ordering with std::set or std::map because they require
deterministic iteration order, this PR uses InsertOrdered{Set,Map} instead.
Diffstat (limited to 'src/wasm/wasm-validator.cpp')
| -rw-r--r-- | src/wasm/wasm-validator.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wasm/wasm-validator.cpp b/src/wasm/wasm-validator.cpp index 3079ad0bb..d82542668 100644 --- a/src/wasm/wasm-validator.cpp +++ b/src/wasm/wasm-validator.cpp @@ -224,7 +224,7 @@ struct FunctionValidator : public WalkerPass<PostWalker<FunctionValidator>> { std::unordered_set<Name> delegateTargetNames; std::unordered_set<Name> rethrowTargetNames; - std::set<Type> returnTypes; // types used in returns + std::unordered_set<Type> returnTypes; // types used in returns // Binaryen IR requires that label names must be unique - IR generators must // ensure that |