diff options
| author | Thomas Lively <tlively@google.com> | 2024-08-16 17:53:37 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-16 21:53:37 +0000 |
| commit | 95a4d5de6f65b35a64caf014c2f7febb8a799542 (patch) | |
| tree | e13e24374714b73ee66ece1b14f9a6daf910e43a /src/wasm/wasm-validator.cpp | |
| parent | 958ff4115e542ef1d0ae712f4961e342386efe54 (diff) | |
| download | binaryen-95a4d5de6f65b35a64caf014c2f7febb8a799542.tar.gz binaryen-95a4d5de6f65b35a64caf014c2f7febb8a799542.tar.bz2 binaryen-95a4d5de6f65b35a64caf014c2f7febb8a799542.zip | |
Fix direct comparisons with unshared basic heap types (#6845)
Audit the remaining ocurrences of `== HeapType::` and fix those that did
not handle shared types correctly. Add tests for some of the fixes;
others are NFC but clarify the code.
Diffstat (limited to 'src/wasm/wasm-validator.cpp')
| -rw-r--r-- | src/wasm/wasm-validator.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wasm/wasm-validator.cpp b/src/wasm/wasm-validator.cpp index 758ae158e..0bdc18658 100644 --- a/src/wasm/wasm-validator.cpp +++ b/src/wasm/wasm-validator.cpp @@ -2769,7 +2769,7 @@ void FunctionValidator::visitCallRef(CallRef* curr) { getModule()->features.hasGC(), curr, "call_ref requires gc [--enable-gc]"); if (curr->target->type == Type::unreachable || (curr->target->type.isRef() && - curr->target->type.getHeapType() == HeapType::nofunc)) { + curr->target->type.getHeapType().isMaybeShared(HeapType::nofunc))) { return; } if (shouldBeTrue(curr->target->type.isFunction(), |