diff options
| author | Sam Clegg <sbc@chromium.org> | 2021-11-23 16:04:50 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-24 00:04:50 +0000 |
| commit | 0bf6ff7922473c37265f6dd601f889a4476ad600 (patch) | |
| tree | 40ebfb38d4e845c2d6f28599e8ce5dd3e452395b /src/wasm2js.h | |
| parent | a8dd9e83be8db755294f9e78b8f3466d1d03c1de (diff) | |
| download | binaryen-0bf6ff7922473c37265f6dd601f889a4476ad600.tar.gz binaryen-0bf6ff7922473c37265f6dd601f889a4476ad600.tar.bz2 binaryen-0bf6ff7922473c37265f6dd601f889a4476ad600.zip | |
wasm2js: Don't assume the existence of js assert function (#4357)
Its seems that with this emscripten change DCE is able to remove
the `assert` JS runtime function making this call to assert fail
with `ReferenceError: assert is not defined`.
Diffstat (limited to 'src/wasm2js.h')
| -rw-r--r-- | src/wasm2js.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wasm2js.h b/src/wasm2js.h index ba5798285..7c9bef0ba 100644 --- a/src/wasm2js.h +++ b/src/wasm2js.h @@ -2868,7 +2868,7 @@ void Wasm2JSGlue::emitSpecialSupport() { } else if (import->base == ABI::wasm2js::ATOMIC_RMW_I64) { out << R"( function wasm2js_atomic_rmw_i64(op, bytes, offset, ptr, valueLow, valueHigh) { - assert(bytes == 8); // TODO: support 1, 2, 4 as well + // TODO: support bytes=1, 2, 4 as well as 8. var view = new BigInt64Array(bufferView.buffer); // TODO cache ptr = (ptr + offset) >> 3; var value = BigInt(valueLow >>> 0) | (BigInt(valueHigh >>> 0) << BigInt(32)); |