diff options
| author | Alon Zakai <azakai@google.com> | 2023-10-04 11:07:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-04 11:07:00 -0700 |
| commit | 1e17dfb695a19d5d41f1f88411fbcbc5f2408c8f (patch) | |
| tree | d171071c9cbdbf571a5e1175d922c08e9e0397b1 /src/wasm | |
| parent | 2abc1a80d42ccd3d8e85543d104b5a6dee127248 (diff) | |
| download | binaryen-1e17dfb695a19d5d41f1f88411fbcbc5f2408c8f.tar.gz binaryen-1e17dfb695a19d5d41f1f88411fbcbc5f2408c8f.tar.bz2 binaryen-1e17dfb695a19d5d41f1f88411fbcbc5f2408c8f.zip | |
Work around a gcc 13 issue with signbit that made us not compute fmin of -0 properly (#5994)
Diffstat (limited to 'src/wasm')
| -rw-r--r-- | src/wasm/literal.cpp | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/src/wasm/literal.cpp b/src/wasm/literal.cpp index 075028127..4bae54693 100644 --- a/src/wasm/literal.cpp +++ b/src/wasm/literal.cpp @@ -1526,8 +1526,12 @@ Literal Literal::min(const Literal& other) const { if (std::isnan(r)) { return standardizeNaN(Literal(r)); } + // This code is written in a form that avoids a gcc 13 bug, see + // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111694 if (l == r && l == 0) { - return Literal(std::signbit(l) ? l : r); + auto lSigned = std::signbit(l); + auto rSigned = std::signbit(r); + return Literal(lSigned || rSigned ? -0.0f : 0.0f); } return Literal(std::min(l, r)); } @@ -1540,7 +1544,9 @@ Literal Literal::min(const Literal& other) const { return standardizeNaN(Literal(r)); } if (l == r && l == 0) { - return Literal(std::signbit(l) ? l : r); + auto lSigned = std::signbit(l); + auto rSigned = std::signbit(r); + return Literal(lSigned || rSigned ? -0.0 : 0.0); } return Literal(std::min(l, r)); } @@ -1560,7 +1566,9 @@ Literal Literal::max(const Literal& other) const { return standardizeNaN(Literal(r)); } if (l == r && l == 0) { - return Literal(std::signbit(l) ? r : l); + auto lSigned = std::signbit(l); + auto rSigned = std::signbit(r); + return Literal(lSigned && rSigned ? -0.0f : 0.0f); } return Literal(std::max(l, r)); } @@ -1573,7 +1581,9 @@ Literal Literal::max(const Literal& other) const { return standardizeNaN(Literal(r)); } if (l == r && l == 0) { - return Literal(std::signbit(l) ? r : l); + auto lSigned = std::signbit(l); + auto rSigned = std::signbit(r); + return Literal(lSigned && rSigned ? -0.0 : 0.0); } return Literal(std::max(l, r)); } |