Remove `Push` (#2867)

Push and Pop have been superseded by tuples for their original
intended purpose of supporting multivalue. Pop is still used to
represent block arguments for exception handling, but there are no
plans to use Push for anything now or in the future.

3 files changed, 0 insertions, 21 deletions

diff --git a/src/wasm/wasm-s-parser.cpp b/src/wasm/wasm-s-parser.cpp
index 65351fe99..7ca8dd131 100644
--- a/src/wasm/wasm-s-parser.cpp
+++ b/src/wasm/wasm-s-parser.cpp
@@ -1581,13 +1581,6 @@ Expression* SExpressionWasmBuilder::makeMemoryFill(Element& s) {
   return ret;
 }
 
-Expression* SExpressionWasmBuilder::makePush(Element& s) {
-  auto ret = allocator.alloc<Push>();
-  ret->value = parseExpression(s[1]);
-  ret->finalize();
-  return ret;
-}
-
 Expression* SExpressionWasmBuilder::makePop(Type type) {
   auto ret = allocator.alloc<Pop>();
   ret->type = type;
diff --git a/src/wasm/wasm-stack.cpp b/src/wasm/wasm-stack.cpp
index 3c5122c10..58fa3f2ef 100644
--- a/src/wasm/wasm-stack.cpp
+++ b/src/wasm/wasm-stack.cpp
@@ -1707,10 +1707,6 @@ void BinaryInstWriter::visitDrop(Drop* curr) {
   }
 }
 
-void BinaryInstWriter::visitPush(Push* curr) {
-  // Turns into nothing in the binary format
-}
-
 void BinaryInstWriter::visitPop(Pop* curr) {
   // Turns into nothing in the binary format
 }
diff --git a/src/wasm/wasm.cpp b/src/wasm/wasm.cpp
index bce1aa4de..704e48e88 100644
--- a/src/wasm/wasm.cpp
+++ b/src/wasm/wasm.cpp
@@ -171,8 +171,6 @@ const char* getExpressionName(Expression* curr) {
       return "memory_copy";
     case Expression::Id::MemoryFillId:
       return "memory_fill";
-    case Expression::Id::PushId:
-      return "push";
     case Expression::Id::PopId:
       return "pop";
     case Expression::Id::RefNullId:
@@ -913,14 +911,6 @@ void BrOnExn::finalize() {
   }
 }
 
-void Push::finalize() {
-  if (value->type == Type::unreachable) {
-    type = Type::unreachable;
-  } else {
-    type = Type::none;
-  }
-}
-
 void TupleMake::finalize() {
   std::vector<Type> types;
   for (auto* op : operands) {