diff options
author | Alon Zakai <azakai@google.com> | 2024-10-18 10:32:34 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-18 10:32:34 -0700 |
commit | 0b882b9e60f05db9e56f0c35cfbb38eb87619a76 (patch) | |
tree | 081627403ef93daefe1538da40a4e892edb760f4 /src | |
parent | 795cf2895f713e8b05924e2a1e24a4d2de3ebcf5 (diff) | |
download | binaryen-0b882b9e60f05db9e56f0c35cfbb38eb87619a76.tar.gz binaryen-0b882b9e60f05db9e56f0c35cfbb38eb87619a76.tar.bz2 binaryen-0b882b9e60f05db9e56f0c35cfbb38eb87619a76.zip |
[GC] Ignore public types in SignatureRefining (#7022)
Similar to #7017 and #7018
Diffstat (limited to 'src')
-rw-r--r-- | src/passes/SignatureRefining.cpp | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/src/passes/SignatureRefining.cpp b/src/passes/SignatureRefining.cpp index ae124dc79..db71c167a 100644 --- a/src/passes/SignatureRefining.cpp +++ b/src/passes/SignatureRefining.cpp @@ -147,18 +147,11 @@ struct SignatureRefining : public Pass { } } - // We cannot alter the signature of an exported function, as the outside may - // notice us doing so. For example, if we turn a parameter from nullable - // into non-nullable then callers sending a null will break. Put another - // way, we need to see all callers to refine types, and for exports we - // cannot do so. - // TODO If a function type is passed we should also mark the types used - // there, etc., recursively. For now this code just handles the top- - // level type, which is enough to keep the fuzzer from erroring. More - // generally, we need to decide about adding a "closed-world" flag of - // some kind. - for (auto* exportedFunc : ExportUtils::getExportedFunctions(*module)) { - allInfo[exportedFunc->type].canModify = false; + // Find the public types, which we must not modify. + for (auto type : ModuleUtils::getPublicHeapTypes(*module)) { + if (type.isFunction()) { + allInfo[type].canModify = false; + } } // For now, do not optimize types that have subtypes. When we modify such a |