[NFC] Remove an ancient hack in ReFinalize (#5183)

Poking in the git history, this was some kind of hack for a problem that appears to
no longer exist since at least 5 years ago.

Logically, refinalize should never change a type from unreachable to none, or at
least if we have a place that does this, we should manually do the necessary things
around that, like updating the function's return type. The opposite, none (or anything
else) to unreachable is the common case, where we use refinalize to propagate
that type upwards.

Fuzzing also finds no issues.

2 files changed, 0 insertions, 11 deletions

diff --git a/src/ir/ReFinalize.cpp b/src/ir/ReFinalize.cpp
index 3a5e4172d..1e77630ab 100644
--- a/src/ir/ReFinalize.cpp
+++ b/src/ir/ReFinalize.cpp
@@ -188,15 +188,6 @@ void ReFinalize::visitStringSliceIter(StringSliceIter* curr) {
   curr->finalize();
 }
 
-void ReFinalize::visitFunction(Function* curr) {
-  // we may have changed the body from unreachable to none, which might be bad
-  // if the function has a return value
-  if (curr->getResults() != Type::none && curr->body->type == Type::none) {
-    Builder builder(*getModule());
-    curr->body = builder.blockify(curr->body, builder.makeUnreachable());
-  }
-}
-
 void ReFinalize::visitExport(Export* curr) { WASM_UNREACHABLE("unimp"); }
 void ReFinalize::visitGlobal(Global* curr) { WASM_UNREACHABLE("unimp"); }
 void ReFinalize::visitTable(Table* curr) { WASM_UNREACHABLE("unimp"); }
diff --git a/src/ir/utils.h b/src/ir/utils.h
index 4f4e5657b..72aa701bb 100644
--- a/src/ir/utils.h
+++ b/src/ir/utils.h
@@ -138,8 +138,6 @@ struct ReFinalize
 
 #include "wasm-delegations.def"
 
-  void visitFunction(Function* curr);
-
   void visitExport(Export* curr);
   void visitGlobal(Global* curr);
   void visitTable(Table* curr);