[NFC] Remove redundant code from EffectAnalyzer (#5754)

This PR removes a check for

transfersControlFlow() && other.trap

which is already checked higher up in the code, here:

transfersControlFlow() && other.hasSideEffects()

In

binaryen/src/ir/effects.h , lines 223 to 224

That last code handles the first code because trapping is part
of hasSideEffects().

1 files changed, 0 insertions, 5 deletions

diff --git a/src/ir/effects.h b/src/ir/effects.h
index 833da2540..29a6375ad 100644
--- a/src/ir/effects.h
+++ b/src/ir/effects.h
@@ -264,11 +264,6 @@ public:
         return true;
       }
     }
-    // We are ok to reorder implicit traps, but not conditionalize them.
-    if ((trap && other.transfersControlFlow()) ||
-        (other.trap && transfersControlFlow())) {
-      return true;
-    }
     // Note that the above includes disallowing the reordering of a trap with an
     // exception (as an exception can transfer control flow inside the current
     // function, so transfersControlFlow would be true) - while we allow the