diff options
author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2019-12-11 17:12:37 -0800 |
---|---|---|
committer | Alon Zakai <azakai@google.com> | 2019-12-11 17:12:37 -0800 |
commit | 759c485a9f35bd859d43b86b02e1397a669fa469 (patch) | |
tree | a5c7475002b406e35c6d1e5c2d843000947ef192 /test/binaryen.js/hello-world.js | |
parent | acd786dbd1e59f9d105c4ec8603c2ff46f233649 (diff) | |
download | binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.tar.gz binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.tar.bz2 binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.zip |
Remove FunctionType (#2510)
Function signatures were previously redundantly stored on Function
objects as well as on FunctionType objects. These two signature
representations had to always be kept in sync, which was error-prone
and needlessly complex. This PR takes advantage of the new ability of
Type to represent multiple value types by consolidating function
signatures as a pair of Types (params and results) stored on the
Function object.
Since there are no longer module-global named function types,
significant changes had to be made to the printing and emitting of
function types, as well as their parsing and manipulation in various
passes.
The C and JS APIs and their tests also had to be updated to remove
named function types.
Diffstat (limited to 'test/binaryen.js/hello-world.js')
-rw-r--r-- | test/binaryen.js/hello-world.js | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/test/binaryen.js/hello-world.js b/test/binaryen.js/hello-world.js index 82867f53c..414e5bfd1 100644 --- a/test/binaryen.js/hello-world.js +++ b/test/binaryen.js/hello-world.js @@ -8,10 +8,6 @@ function assert(x) { // Create a module to work on var module = new Binaryen.Module(); -// Create a function type for i32 (i32, i32) (i.e., return i32, pass two -// i32 params) -var iii = module.addFunctionType('iii', Binaryen.i32, [Binaryen.i32, Binaryen.i32]); - // Start to create the function, starting with the contents: Get the 0 and // 1 arguments, and add them, then return them var left = module.local.get(0, Binaryen.i32); @@ -21,7 +17,8 @@ var ret = module.return(add); // Create the add function // Note: no additional local variables (that's the []) -module.addFunction('adder', iii, [], ret); +var ii = Binaryen.createType([Binaryen.i32, Binaryen.i32]) +module.addFunction('adder', ii, Binaryen.i32, [], ret); // Export the function, so we can call it later (for simplicity we // export it as the same name as it has internally) @@ -54,4 +51,3 @@ console.log(); // Call the code! console.log('an addition: ' + wasm.exports.adder(40, 2)); - |