diff options
author | Alon Zakai <azakai@google.com> | 2020-10-19 10:20:34 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-19 10:20:34 -0700 |
commit | 3f1b6ca3f3dc852aaa0a427b4db340e75c5bb693 (patch) | |
tree | 5449b5bf1554d8c8643be20c2ab7fbd54a944640 /test/dynamicLibrary.asm.js | |
parent | 770a042535cd901902cd23410d9a9488dfc020e2 (diff) | |
download | binaryen-3f1b6ca3f3dc852aaa0a427b4db340e75c5bb693.tar.gz binaryen-3f1b6ca3f3dc852aaa0a427b4db340e75c5bb693.tar.bz2 binaryen-3f1b6ca3f3dc852aaa0a427b4db340e75c5bb693.zip |
Fix validateGlobally usage in validator, and an i64-to-i32 bug hidden by it (#3253)
validateGlobally means that we can't do lookups on the module. A few places
were missing that, or had it wrong. I think the reason for the wrong usages is
that we used to have types on the module, and then removed that, so more is
now validatable actually.
This uncovered a real bug, where i64-to-32 would ignore an unreachable
parameter of a call_indirect. That's bad, since if the type is i64, we need
to replace it with two parameters. To fix that, just handle unreachability
there, using the existing logic (which skips the call_indirect entirely in
this case).
Diffstat (limited to 'test/dynamicLibrary.asm.js')
0 files changed, 0 insertions, 0 deletions