diff options
| author | Alon Zakai <alonzakai@gmail.com> | 2018-07-23 15:16:13 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-23 15:16:13 -0700 |
| commit | f7d9536ad653a9e6cc059c1539c2807e754be264 (patch) | |
| tree | 5095d28a3d14a3d55cc86eeff1e79633f2f3f1c1 /test/dynamicLibrary.asm.js | |
| parent | 2f5774ca60119189b5123f170f39486e1efe94e6 (diff) | |
| download | binaryen-f7d9536ad653a9e6cc059c1539c2807e754be264.tar.gz binaryen-f7d9536ad653a9e6cc059c1539c2807e754be264.tar.bz2 binaryen-f7d9536ad653a9e6cc059c1539c2807e754be264.zip | |
Clarify what function-parallel passes can do, and fix an asm2wasm bug (#1627)
The problem this fixes is that we made precompute look at globals in #1622, while asm2wasm was creating globals while adding functions and optimizing them - which could race. This was caught by threadSanitizer (with low frequency, so we missed it on the initial landing).
The underlying issue is that function-parallel passes should be able to read global state, just not modify it, and not read other functions' contents (which is why the Call node has a name, not a pointer to a function). This PR clarifies that in the docs, and fixes asm2wasm by not handling function bodies in parallel to creating globals.
Diffstat (limited to 'test/dynamicLibrary.asm.js')
0 files changed, 0 insertions, 0 deletions