diff options
| author | Alon Zakai <alonzakai@gmail.com> | 2018-04-07 10:19:58 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-07 10:19:58 -0700 |
| commit | e42e1e3d4a5c67c0c066fe397b456ab8d41a78fd (patch) | |
| tree | 6f833f2ede0b626840e2b7b76fec0e712ff0680b /test/elided-br.wasm.fromBinary | |
| parent | 5b5789495a97602869f18d552b2a9e1814edefae (diff) | |
| download | binaryen-e42e1e3d4a5c67c0c066fe397b456ab8d41a78fd.tar.gz binaryen-e42e1e3d4a5c67c0c066fe397b456ab8d41a78fd.tar.bz2 binaryen-e42e1e3d4a5c67c0c066fe397b456ab8d41a78fd.zip | |
Handle literally unreachable brs (#1497)
The optimization in #1495 had a bug which was found by the fuzzer: our binary format parsing will not emit unreachable code (it may be stacky, so we ignore it). However, while parsing it we note breaks that are taken there, and then we removed that code, leading to a state where a break was not taken in the code, but we thought it was.
This PR clarifies the difference between unreachable code in the wasm sense (anything from the start of a block til an unreachable is "reachable") and the literal sense (even that code at the start may not be literally reachable if the block is not reachable), and then we use literal unreachability to know what code will be ignored and therefore we should ignore breaks in.
Diffstat (limited to 'test/elided-br.wasm.fromBinary')
| -rw-r--r-- | test/elided-br.wasm.fromBinary | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/test/elided-br.wasm.fromBinary b/test/elided-br.wasm.fromBinary new file mode 100644 index 000000000..c248ded7d --- /dev/null +++ b/test/elided-br.wasm.fromBinary @@ -0,0 +1,9 @@ +(module + (type $0 (func)) + (func $0 (; 0 ;) (type $0) + (block $label$1 + (unreachable) + ) + ) +) + |