diff options
author | Alon Zakai <alonzakai@gmail.com> | 2018-02-16 08:18:55 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-02-16 08:18:55 -0800 |
commit | 27000a9bfa616133c9368214386fd0416f398dfe (patch) | |
tree | dec89c6aabbed596fa7671432a071a889b4fb4a9 /test/empty_imported_table.2asm.js | |
parent | 85ae8cc6ffeffa65ff30d17649a0d8589dab2b00 (diff) | |
download | binaryen-27000a9bfa616133c9368214386fd0416f398dfe.tar.gz binaryen-27000a9bfa616133c9368214386fd0416f398dfe.tar.bz2 binaryen-27000a9bfa616133c9368214386fd0416f398dfe.zip |
determinism fix: hash results may differ between runs (#1431)
Hash results may differ between runs, as they can depend on pointers. In remove-duplicate-functions, that shouldn't matter, except that we only considered the first item in each hash group vs the others (to avoid O(N^2)), which is fine except for hash collisions (collisions mean 2 groups are merged into one, and considering just the first item vs the rest we miss out on the other duplicates in that single group). And hash collisions do occur (rarely) in practice. Instead, consider all comparisons in each hash group, which should be fine unless we have large amounts of hash collisions.
Diffstat (limited to 'test/empty_imported_table.2asm.js')
0 files changed, 0 insertions, 0 deletions