[FP16] Implement madd and nmadd. (#6878)

Specified at
https://github.com/WebAssembly/half-precision/blob/main/proposals/half-precision/Overview.md

A few notes:
- The F32x4 and F64x2 versions of madd and nmadd are missing spect
tests.
- For madd, the implementation was incorrectly doing `(b*c)+a` where it
should be `(a*b)+c`.
- For nmadd, the implementation was incorrectly doing `(-b*c)+a` where
it should be `-(a*b)+c`.
- There doesn't appear to be a great way to actually implement a fused
nmadd, but the spec allows the double rounded version I added.

1 files changed, 96 insertions, 30 deletions

diff --git a/test/lit/basic/f16.wast b/test/lit/basic/f16.wast
index 2e5ac57dd..ba806bb57 100644
--- a/test/lit/basic/f16.wast
+++ b/test/lit/basic/f16.wast
@@ -17,19 +17,21 @@
 
  ;; CHECK-TEXT:      (type $1 (func (param v128) (result v128)))
 
- ;; CHECK-TEXT:      (type $2 (func (param i32) (result f32)))
+ ;; CHECK-TEXT:      (type $2 (func (param v128 v128 v128) (result v128)))
 
- ;; CHECK-TEXT:      (type $3 (func (param i32 f32)))
+ ;; CHECK-TEXT:      (type $3 (func (param i32) (result f32)))
 
- ;; CHECK-TEXT:      (type $4 (func (param f32) (result v128)))
+ ;; CHECK-TEXT:      (type $4 (func (param i32 f32)))
 
- ;; CHECK-TEXT:      (type $5 (func (param v128) (result f32)))
+ ;; CHECK-TEXT:      (type $5 (func (param f32) (result v128)))
 
- ;; CHECK-TEXT:      (type $6 (func (param v128 f32) (result v128)))
+ ;; CHECK-TEXT:      (type $6 (func (param v128) (result f32)))
+
+ ;; CHECK-TEXT:      (type $7 (func (param v128 f32) (result v128)))
 
  ;; CHECK-TEXT:      (memory $0 1 1)
 
- ;; CHECK-TEXT:      (func $f32.load_f16 (type $2) (param $0 i32) (result f32)
+ ;; CHECK-TEXT:      (func $f32.load_f16 (type $3) (param $0 i32) (result f32)
  ;; CHECK-TEXT-NEXT:  (f32.load_f16
  ;; CHECK-TEXT-NEXT:   (local.get $0)
  ;; CHECK-TEXT-NEXT:  )
@@ -38,19 +40,21 @@
 
  ;; CHECK-BIN:      (type $1 (func (param v128) (result v128)))
 
- ;; CHECK-BIN:      (type $2 (func (param i32) (result f32)))
+ ;; CHECK-BIN:      (type $2 (func (param v128 v128 v128) (result v128)))
+
+ ;; CHECK-BIN:      (type $3 (func (param i32) (result f32)))
 
- ;; CHECK-BIN:      (type $3 (func (param i32 f32)))
+ ;; CHECK-BIN:      (type $4 (func (param i32 f32)))
 
- ;; CHECK-BIN:      (type $4 (func (param f32) (result v128)))
+ ;; CHECK-BIN:      (type $5 (func (param f32) (result v128)))
 
- ;; CHECK-BIN:      (type $5 (func (param v128) (result f32)))
+ ;; CHECK-BIN:      (type $6 (func (param v128) (result f32)))
 
- ;; CHECK-BIN:      (type $6 (func (param v128 f32) (result v128)))
+ ;; CHECK-BIN:      (type $7 (func (param v128 f32) (result v128)))
 
  ;; CHECK-BIN:      (memory $0 1 1)
 
- ;; CHECK-BIN:      (func $f32.load_f16 (type $2) (param $0 i32) (result f32)
+ ;; CHECK-BIN:      (func $f32.load_f16 (type $3) (param $0 i32) (result f32)
  ;; CHECK-BIN-NEXT:  (f32.load_f16
  ;; CHECK-BIN-NEXT:   (local.get $0)
  ;; CHECK-BIN-NEXT:  )
@@ -60,13 +64,13 @@
    (local.get $0)
   )
  )
- ;; CHECK-TEXT:      (func $f32.store_f16 (type $3) (param $0 i32) (param $1 f32)
+ ;; CHECK-TEXT:      (func $f32.store_f16 (type $4) (param $0 i32) (param $1 f32)
  ;; CHECK-TEXT-NEXT:  (f32.store_f16
  ;; CHECK-TEXT-NEXT:   (local.get $0)
  ;; CHECK-TEXT-NEXT:   (local.get $1)
  ;; CHECK-TEXT-NEXT:  )
  ;; CHECK-TEXT-NEXT: )
- ;; CHECK-BIN:      (func $f32.store_f16 (type $3) (param $0 i32) (param $1 f32)
+ ;; CHECK-BIN:      (func $f32.store_f16 (type $4) (param $0 i32) (param $1 f32)
  ;; CHECK-BIN-NEXT:  (f32.store_f16
  ;; CHECK-BIN-NEXT:   (local.get $0)
  ;; CHECK-BIN-NEXT:   (local.get $1)
@@ -79,12 +83,12 @@
   )
  )
 
- ;; CHECK-TEXT:      (func $f16x8.splat (type $4) (param $0 f32) (result v128)
+ ;; CHECK-TEXT:      (func $f16x8.splat (type $5) (param $0 f32) (result v128)
  ;; CHECK-TEXT-NEXT:  (f16x8.splat
  ;; CHECK-TEXT-NEXT:   (local.get $0)
  ;; CHECK-TEXT-NEXT:  )
  ;; CHECK-TEXT-NEXT: )
- ;; CHECK-BIN:      (func $f16x8.splat (type $4) (param $0 f32) (result v128)
+ ;; CHECK-BIN:      (func $f16x8.splat (type $5) (param $0 f32) (result v128)
  ;; CHECK-BIN-NEXT:  (f16x8.splat
  ;; CHECK-BIN-NEXT:   (local.get $0)
  ;; CHECK-BIN-NEXT:  )
@@ -95,12 +99,12 @@
   )
  )
 
-  ;; CHECK-TEXT:      (func $f16x8.extract_lane (type $5) (param $0 v128) (result f32)
+  ;; CHECK-TEXT:      (func $f16x8.extract_lane (type $6) (param $0 v128) (result f32)
   ;; CHECK-TEXT-NEXT:  (f16x8.extract_lane 0
   ;; CHECK-TEXT-NEXT:   (local.get $0)
   ;; CHECK-TEXT-NEXT:  )
   ;; CHECK-TEXT-NEXT: )
-  ;; CHECK-BIN:      (func $f16x8.extract_lane (type $5) (param $0 v128) (result f32)
+  ;; CHECK-BIN:      (func $f16x8.extract_lane (type $6) (param $0 v128) (result f32)
   ;; CHECK-BIN-NEXT:  (f16x8.extract_lane 0
   ;; CHECK-BIN-NEXT:   (local.get $0)
   ;; CHECK-BIN-NEXT:  )
@@ -111,13 +115,13 @@
   )
  )
 
-  ;; CHECK-TEXT:      (func $f16x8.replace_lane (type $6) (param $0 v128) (param $1 f32) (result v128)
+  ;; CHECK-TEXT:      (func $f16x8.replace_lane (type $7) (param $0 v128) (param $1 f32) (result v128)
   ;; CHECK-TEXT-NEXT:  (f16x8.replace_lane 0
   ;; CHECK-TEXT-NEXT:   (local.get $0)
   ;; CHECK-TEXT-NEXT:   (local.get $1)
   ;; CHECK-TEXT-NEXT:  )
   ;; CHECK-TEXT-NEXT: )
-  ;; CHECK-BIN:      (func $f16x8.replace_lane (type $6) (param $0 v128) (param $1 f32) (result v128)
+  ;; CHECK-BIN:      (func $f16x8.replace_lane (type $7) (param $0 v128) (param $1 f32) (result v128)
   ;; CHECK-BIN-NEXT:  (f16x8.replace_lane 0
   ;; CHECK-BIN-NEXT:   (local.get $0)
   ;; CHECK-BIN-NEXT:   (local.get $1)
@@ -486,49 +490,95 @@
    (local.get $0)
   )
  )
+  ;; CHECK-TEXT:      (func $f16x8.relaxed_madd (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+  ;; CHECK-TEXT-NEXT:  (f16x8.relaxed_madd
+  ;; CHECK-TEXT-NEXT:   (local.get $0)
+  ;; CHECK-TEXT-NEXT:   (local.get $1)
+  ;; CHECK-TEXT-NEXT:   (local.get $2)
+  ;; CHECK-TEXT-NEXT:  )
+  ;; CHECK-TEXT-NEXT: )
+  ;; CHECK-BIN:      (func $f16x8.relaxed_madd (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+  ;; CHECK-BIN-NEXT:  (f16x8.relaxed_madd
+  ;; CHECK-BIN-NEXT:   (local.get $0)
+  ;; CHECK-BIN-NEXT:   (local.get $1)
+  ;; CHECK-BIN-NEXT:   (local.get $2)
+  ;; CHECK-BIN-NEXT:  )
+  ;; CHECK-BIN-NEXT: )
+  (func $f16x8.relaxed_madd (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+  (f16x8.relaxed_madd
+   (local.get $0)
+   (local.get $1)
+   (local.get $2)
+  )
+ )
+
+
+ ;; CHECK-TEXT:      (func $f16x8.relaxed_nmadd (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+ ;; CHECK-TEXT-NEXT:  (f16x8.relaxed_nmadd
+ ;; CHECK-TEXT-NEXT:   (local.get $0)
+ ;; CHECK-TEXT-NEXT:   (local.get $1)
+ ;; CHECK-TEXT-NEXT:   (local.get $2)
+ ;; CHECK-TEXT-NEXT:  )
+ ;; CHECK-TEXT-NEXT: )
+ ;; CHECK-BIN:      (func $f16x8.relaxed_nmadd (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+ ;; CHECK-BIN-NEXT:  (f16x8.relaxed_nmadd
+ ;; CHECK-BIN-NEXT:   (local.get $0)
+ ;; CHECK-BIN-NEXT:   (local.get $1)
+ ;; CHECK-BIN-NEXT:   (local.get $2)
+ ;; CHECK-BIN-NEXT:  )
+ ;; CHECK-BIN-NEXT: )
+ (func $f16x8.relaxed_nmadd (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+  (f16x8.relaxed_nmadd
+   (local.get $0)
+   (local.get $1)
+   (local.get $2)
+  )
+ )
 )
 ;; CHECK-BIN-NODEBUG:      (type $0 (func (param v128 v128) (result v128)))
 
 ;; CHECK-BIN-NODEBUG:      (type $1 (func (param v128) (result v128)))
 
-;; CHECK-BIN-NODEBUG:      (type $2 (func (param i32) (result f32)))
+;; CHECK-BIN-NODEBUG:      (type $2 (func (param v128 v128 v128) (result v128)))
 
-;; CHECK-BIN-NODEBUG:      (type $3 (func (param i32 f32)))
+;; CHECK-BIN-NODEBUG:      (type $3 (func (param i32) (result f32)))
 
-;; CHECK-BIN-NODEBUG:      (type $4 (func (param f32) (result v128)))
+;; CHECK-BIN-NODEBUG:      (type $4 (func (param i32 f32)))
 
-;; CHECK-BIN-NODEBUG:      (type $5 (func (param v128) (result f32)))
+;; CHECK-BIN-NODEBUG:      (type $5 (func (param f32) (result v128)))
 
-;; CHECK-BIN-NODEBUG:      (type $6 (func (param v128 f32) (result v128)))
+;; CHECK-BIN-NODEBUG:      (type $6 (func (param v128) (result f32)))
+
+;; CHECK-BIN-NODEBUG:      (type $7 (func (param v128 f32) (result v128)))
 
 ;; CHECK-BIN-NODEBUG:      (memory $0 1 1)
 
-;; CHECK-BIN-NODEBUG:      (func $0 (type $2) (param $0 i32) (result f32)
+;; CHECK-BIN-NODEBUG:      (func $0 (type $3) (param $0 i32) (result f32)
 ;; CHECK-BIN-NODEBUG-NEXT:  (f32.load_f16
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:  )
 ;; CHECK-BIN-NODEBUG-NEXT: )
 
-;; CHECK-BIN-NODEBUG:      (func $1 (type $3) (param $0 i32) (param $1 f32)
+;; CHECK-BIN-NODEBUG:      (func $1 (type $4) (param $0 i32) (param $1 f32)
 ;; CHECK-BIN-NODEBUG-NEXT:  (f32.store_f16
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $1)
 ;; CHECK-BIN-NODEBUG-NEXT:  )
 ;; CHECK-BIN-NODEBUG-NEXT: )
 
-;; CHECK-BIN-NODEBUG:      (func $2 (type $4) (param $0 f32) (result v128)
+;; CHECK-BIN-NODEBUG:      (func $2 (type $5) (param $0 f32) (result v128)
 ;; CHECK-BIN-NODEBUG-NEXT:  (f16x8.splat
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:  )
 ;; CHECK-BIN-NODEBUG-NEXT: )
 
-;; CHECK-BIN-NODEBUG:      (func $3 (type $5) (param $0 v128) (result f32)
+;; CHECK-BIN-NODEBUG:      (func $3 (type $6) (param $0 v128) (result f32)
 ;; CHECK-BIN-NODEBUG-NEXT:  (f16x8.extract_lane 0
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:  )
 ;; CHECK-BIN-NODEBUG-NEXT: )
 
-;; CHECK-BIN-NODEBUG:      (func $4 (type $6) (param $0 v128) (param $1 f32) (result v128)
+;; CHECK-BIN-NODEBUG:      (func $4 (type $7) (param $0 v128) (param $1 f32) (result v128)
 ;; CHECK-BIN-NODEBUG-NEXT:  (f16x8.replace_lane 0
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $1)
@@ -674,3 +724,19 @@
 ;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
 ;; CHECK-BIN-NODEBUG-NEXT:  )
 ;; CHECK-BIN-NODEBUG-NEXT: )
+
+;; CHECK-BIN-NODEBUG:      (func $26 (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+;; CHECK-BIN-NODEBUG-NEXT:  (f16x8.relaxed_madd
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $1)
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $2)
+;; CHECK-BIN-NODEBUG-NEXT:  )
+;; CHECK-BIN-NODEBUG-NEXT: )
+
+;; CHECK-BIN-NODEBUG:      (func $27 (type $2) (param $0 v128) (param $1 v128) (param $2 v128) (result v128)
+;; CHECK-BIN-NODEBUG-NEXT:  (f16x8.relaxed_nmadd
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $0)
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $1)
+;; CHECK-BIN-NODEBUG-NEXT:   (local.get $2)
+;; CHECK-BIN-NODEBUG-NEXT:  )
+;; CHECK-BIN-NODEBUG-NEXT: )