Consolidate printing of function signatures (#7073)

There were previously two separate code paths for printing function
signatures, one for imported functions and one for declared functions.
The only intended difference was that parameter names were printed for
declared functions but not for imported functions.

Reduce duplication by consolidating the code paths, and add support for
printing names for imported function parameters that have them. Also fix
a bug where empty names were printed as `$` rather than the correct
`$""`.

1 files changed, 22 insertions, 0 deletions

diff --git a/test/lit/basic/imported-params.wast b/test/lit/basic/imported-params.wast
new file mode 100644
index 000000000..c81bf0870
--- /dev/null
+++ b/test/lit/basic/imported-params.wast
@@ -0,0 +1,22 @@
+;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
+
+;; Test that parameter names are preserved for imported functions
+
+;; RUN: wasm-opt %s -S -o - | filecheck %s
+
+(module
+ (import "" "" (func (param i32 i64) (param $x i32) (param $y i64) (param f32 f64)))
+ (import "" "" (func (param $x i32) (param f32 f64) (param $y i64)))
+ (import "" "" (func (param $"" i32)))
+)
+;; CHECK:      (type $0 (func (param i32 i64 i32 i64 f32 f64)))
+
+;; CHECK:      (type $1 (func (param i32 f32 f64 i64)))
+
+;; CHECK:      (type $2 (func (param i32)))
+
+;; CHECK:      (import "" "" (func $fimport$0 (param i32 i64) (param $x i32) (param $y i64) (param f32 f64)))
+
+;; CHECK:      (import "" "" (func $fimport$1 (param $x i32) (param f32 f64) (param $y i64)))
+
+;; CHECK:      (import "" "" (func $fimport$2 (param $"" i32)))