diff options
| author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2021-09-24 14:25:05 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-24 14:25:05 -0700 |
| commit | ab3811dafb27edd81f919d0096630014184b3836 (patch) | |
| tree | 632000d37a75a3c5913bce7b0c17c163b430acbf /test/lit/help/wasm-split.test | |
| parent | a6dbadb8d180aff3c481ad8fd3009a712c11b449 (diff) | |
| download | binaryen-ab3811dafb27edd81f919d0096630014184b3836.tar.gz binaryen-ab3811dafb27edd81f919d0096630014184b3836.tar.bz2 binaryen-ab3811dafb27edd81f919d0096630014184b3836.zip | |
[wasm-split] Disallow mixing --profile, --keep-funcs, and --split-funcs (#4187)
Previously the set of functions to keep was initially empty, then the profile
added new functions to keep, then the --keep-funcs functions were added, then
the --split-funcs functions were removed. This method of composing these
different options was arbitrary and not necessarily intuitive, and it prevented
reasonable workflows from working. For example, providing only a --split-funcs
list would result in all functions being split out not matter which functions
were listed.
To make the behavior of these options, and --split-funcs in particular, more
intuitive, disallow mixing them and when --split-funcs is used, split out only
the listed functions.
Diffstat (limited to 'test/lit/help/wasm-split.test')
| -rw-r--r-- | test/lit/help/wasm-split.test | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/test/lit/help/wasm-split.test b/test/lit/help/wasm-split.test index dd2b5f7e1..fe48e5e25 100644 --- a/test/lit/help/wasm-split.test +++ b/test/lit/help/wasm-split.test @@ -35,21 +35,18 @@ ;; CHECK-NEXT: splitting. ;; CHECK-NEXT: ;; CHECK-NEXT: --keep-funcs [split] Comma-separated list of functions -;; CHECK-NEXT: to keep in the primary module, regardless -;; CHECK-NEXT: of any profile. You can also pass a file -;; CHECK-NEXT: with a list of functions separated by new -;; CHECK-NEXT: lines. To do this, prepend @ before -;; CHECK-NEXT: filename (--keep-funcs @myfile) +;; CHECK-NEXT: to keep in the primary module. The rest +;; CHECK-NEXT: will be split out. Cannot be used with +;; CHECK-NEXT: --profile or --split-funcs. You can also +;; CHECK-NEXT: pass a file with one function per line by +;; CHECK-NEXT: passing @filename. ;; CHECK-NEXT: ;; CHECK-NEXT: --split-funcs [split] Comma-separated list of functions -;; CHECK-NEXT: to split into the secondary module, -;; CHECK-NEXT: regardless of any profile. If there is no -;; CHECK-NEXT: profile, then this defaults to all -;; CHECK-NEXT: functions defined in the module. You can -;; CHECK-NEXT: also pass a file with a list of functions -;; CHECK-NEXT: separated by new lines. To do this, -;; CHECK-NEXT: prepend @ before filename (--split-funcs -;; CHECK-NEXT: @myfile) +;; CHECK-NEXT: to split out to the secondary module. The +;; CHECK-NEXT: rest will be kept. Cannot be used with +;; CHECK-NEXT: --profile or --keep-funcs. You can also +;; CHECK-NEXT: pass a file with one function per line by +;; CHECK-NEXT: passing @filename. ;; CHECK-NEXT: ;; CHECK-NEXT: --primary-output,-o1 [split] Output file for the primary ;; CHECK-NEXT: module. |