diff options
| author | Heejin Ahn <aheejin@gmail.com> | 2024-05-15 12:36:00 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-15 12:36:00 -0700 |
| commit | ae9499448c9221290f46eac26169db378fcd6997 (patch) | |
| tree | 421f530a1bd76b77810c07b0bf0c771ac1c5653f /test/lit/help | |
| parent | b70d8dff27ccea2d4546909dba83bf8cae072aba (diff) | |
| download | binaryen-ae9499448c9221290f46eac26169db378fcd6997.tar.gz binaryen-ae9499448c9221290f46eac26169db378fcd6997.tar.bz2 binaryen-ae9499448c9221290f46eac26169db378fcd6997.zip | |
[EH] Rename option/pass names for new EH (exnref) (#6592)
We settled on the name `WASM_EXNREF` for the new setting in Emscripten
for the name for the new EH option.
https://github.com/emscripten-core/emscripten/blob/2bc5e3156f07e603bc4f3580cf84c038ea99b2df/src/settings.js#L782-L786
"New EH" sounds vague and I'm not sure if "experimental" is really
necessary anyway, given that the potential users of this option is aware
that this is a new spec that has been adopted recently.
To make the option names consistent, this renames `--translate-to-eh`
(the option that only runs the translator) to `--translate-to-exnref`,
and `--experimental-new-eh` to `--emit-exnref` (the option that runs the
translator at the end of the whole pipeline), and renames the pass and
variable names in the code accordingly as well.
In case anyone is using the old option names (and also to make the
Chromium CI pass), this does not delete the old options.
Diffstat (limited to 'test/lit/help')
| -rw-r--r-- | test/lit/help/wasm-opt.test | 13 | ||||
| -rw-r--r-- | test/lit/help/wasm2js.test | 8 |
2 files changed, 16 insertions, 5 deletions
diff --git a/test/lit/help/wasm-opt.test b/test/lit/help/wasm-opt.test index f6497618e..6dafe2c62 100644 --- a/test/lit/help/wasm-opt.test +++ b/test/lit/help/wasm-opt.test @@ -79,7 +79,10 @@ ;; CHECK-NEXT: --new-wat-parser Use the experimental new WAT ;; CHECK-NEXT: parser ;; CHECK-NEXT: -;; CHECK-NEXT: --experimental-new-eh After running all requested +;; CHECK-NEXT: --experimental-new-eh Deprecated; same as +;; CHECK-NEXT: --emit-exnref +;; CHECK-NEXT: +;; CHECK-NEXT: --emit-exnref After running all requested ;; CHECK-NEXT: transformations / optimizations, ;; CHECK-NEXT: translate the instruction to use ;; CHECK-NEXT: the new EH instructions at the @@ -502,8 +505,12 @@ ;; CHECK-NEXT: ;; CHECK-NEXT: --symbolmap (alias for print-function-map) ;; CHECK-NEXT: -;; CHECK-NEXT: --translate-to-new-eh translate old EH instructions to -;; CHECK-NEXT: new ones +;; CHECK-NEXT: --translate-to-exnref translate old Phase 3 EH +;; CHECK-NEXT: instructions to new ones with +;; CHECK-NEXT: exnref +;; CHECK-NEXT: +;; CHECK-NEXT: --translate-to-new-eh deprecated; same as +;; CHECK-NEXT: translate-to-exnref ;; CHECK-NEXT: ;; CHECK-NEXT: --trap-mode-clamp replace trapping operations with ;; CHECK-NEXT: clamping semantics diff --git a/test/lit/help/wasm2js.test b/test/lit/help/wasm2js.test index 13e93c33b..63d43d388 100644 --- a/test/lit/help/wasm2js.test +++ b/test/lit/help/wasm2js.test @@ -452,8 +452,12 @@ ;; CHECK-NEXT: ;; CHECK-NEXT: --symbolmap (alias for print-function-map) ;; CHECK-NEXT: -;; CHECK-NEXT: --translate-to-new-eh translate old EH instructions to -;; CHECK-NEXT: new ones +;; CHECK-NEXT: --translate-to-exnref translate old Phase 3 EH +;; CHECK-NEXT: instructions to new ones with +;; CHECK-NEXT: exnref +;; CHECK-NEXT: +;; CHECK-NEXT: --translate-to-new-eh deprecated; same as +;; CHECK-NEXT: translate-to-exnref ;; CHECK-NEXT: ;; CHECK-NEXT: --trap-mode-clamp replace trapping operations with ;; CHECK-NEXT: clamping semantics |