diff options
| author | Alon Zakai <azakai@google.com> | 2022-08-22 13:53:47 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-22 13:53:47 -0700 |
| commit | 38c084ee386e257389d44c6200a403f74432e1af (patch) | |
| tree | 8e41abd3ad903b9fcb426bf0c4be3dd66a092247 /test/lit/passes/dce_all-features.wast | |
| parent | b24df4d0c4705027fdc6e261aa3f8e4f61dc5c0a (diff) | |
| download | binaryen-38c084ee386e257389d44c6200a403f74432e1af.tar.gz binaryen-38c084ee386e257389d44c6200a403f74432e1af.tar.bz2 binaryen-38c084ee386e257389d44c6200a403f74432e1af.zip | |
Avoid adding new unneeded names to blocks in text roundtripping (#4943)
Previously the wat parser would turn this input:
(block
(nop)
)
into something like this:
(block $block17
(nop)
)
It just added a name all the time, in case the block is referred to by an index
later even though it doesn't have a name.
This PR makes us rountrip more precisely by not adding such names: if there
was no name before, and there is no break by index, then do not add a name.
In addition, this will be useful for non-nullable locals since whether a block has
a name or not matters there. Like #4912, this makes us more regular in our
usage of block names.
Diffstat (limited to 'test/lit/passes/dce_all-features.wast')
| -rw-r--r-- | test/lit/passes/dce_all-features.wast | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/lit/passes/dce_all-features.wast b/test/lit/passes/dce_all-features.wast index 9953e65b6..03b90cc38 100644 --- a/test/lit/passes/dce_all-features.wast +++ b/test/lit/passes/dce_all-features.wast @@ -911,7 +911,7 @@ ;; CHECK-NEXT: ) ;; CHECK-NEXT: (block ;; CHECK-NEXT: (drop - ;; CHECK-NEXT: (block $block (result i64) + ;; CHECK-NEXT: (block (result i64) ;; CHECK-NEXT: (local.set $2 ;; CHECK-NEXT: (local.get $var$0) ;; CHECK-NEXT: ) @@ -956,7 +956,7 @@ ) ;; CHECK: (func $br-gone-means-block-type-changes-then-refinalize-at-end-is-too-late (param $var$0 i32) (result i32) ;; CHECK-NEXT: (block $label$0 - ;; CHECK-NEXT: (block $block + ;; CHECK-NEXT: (block ;; CHECK-NEXT: (nop) ;; CHECK-NEXT: (unreachable) ;; CHECK-NEXT: ) @@ -980,7 +980,7 @@ ) ;; CHECK: (func $br-with-unreachable-value-should-not-give-a-block-a-value (param $var$0 i32) (result i32) ;; CHECK-NEXT: (block $label$0 (result i32) - ;; CHECK-NEXT: (block $block + ;; CHECK-NEXT: (block ;; CHECK-NEXT: (drop ;; CHECK-NEXT: (br_if $label$0 ;; CHECK-NEXT: (i32.const 8) @@ -1150,7 +1150,7 @@ ;; CHECK-NEXT: (i64.const 0) ;; CHECK-NEXT: ) ;; CHECK-NEXT: (if - ;; CHECK-NEXT: (block $block (result i32) + ;; CHECK-NEXT: (block (result i32) ;; CHECK-NEXT: (call $replace-with-unreachable-affects-parent ;; CHECK-NEXT: (f32.const 1) ;; CHECK-NEXT: (i64.const -15917430362925035) @@ -1375,7 +1375,7 @@ ) ;; CHECK: (func $note-loss-of-non-control-flow-children ;; CHECK-NEXT: (block $out - ;; CHECK-NEXT: (block $block + ;; CHECK-NEXT: (block ;; CHECK-NEXT: (nop) ;; CHECK-NEXT: (unreachable) ;; CHECK-NEXT: ) |