diff options
| author | Alon Zakai <azakai@google.com> | 2023-02-16 07:29:55 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-16 07:29:55 -0800 |
| commit | 0cffeb58f88b086ff7b195fc7d2440add92803fc (patch) | |
| tree | 624774b7a4f4905695fc895be6219b08d43c56b2 /test/lit/passes/inlining_splitting.wast | |
| parent | 670b73681c56a42930f65c7a293a062e168c39fc (diff) | |
| download | binaryen-0cffeb58f88b086ff7b195fc7d2440add92803fc.tar.gz binaryen-0cffeb58f88b086ff7b195fc7d2440add92803fc.tar.bz2 binaryen-0cffeb58f88b086ff7b195fc7d2440add92803fc.zip | |
Never flip a call from unreachable to reachable during inlining (#5493)
See example in the new comment. In general, we never want to go from
unreachable to reachable (refinalize doesn't even try), as it misses out on
DCE opportunities. Also it may have validation issues, which is how the
fuzzer found this.
Remove code in the same place that was redundant after the refinalize
was added in #5492. That simplifies some existing testcases slightly, by
removing an unneeded br we added, and now we add a new unreachable
at the end in other cases that need it.
Diffstat (limited to 'test/lit/passes/inlining_splitting.wast')
| -rw-r--r-- | test/lit/passes/inlining_splitting.wast | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/lit/passes/inlining_splitting.wast b/test/lit/passes/inlining_splitting.wast index 2f840a494..9764aa235 100644 --- a/test/lit/passes/inlining_splitting.wast +++ b/test/lit/passes/inlining_splitting.wast @@ -231,7 +231,6 @@ ;; CHECK-NEXT: (br $l) ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) - ;; CHECK-NEXT: (br $__inlined_func$nondefaultable-param) ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) (func $call-nondefaultable-param |