diff options
| author | Roberto Lublinerman <rluble@google.com> | 2024-05-09 14:05:53 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-09 14:05:53 -0700 |
| commit | a816627051c67ae14f6defc8fc5c616ba427a29e (patch) | |
| tree | c7f861c41915279052667e674d4a7811ea9b7c78 /test/lit/passes/j2cl-inline.wast | |
| parent | 712ad9d83953101abec01e5017e306fcb4bf7f70 (diff) | |
| download | binaryen-a816627051c67ae14f6defc8fc5c616ba427a29e.tar.gz binaryen-a816627051c67ae14f6defc8fc5c616ba427a29e.tar.bz2 binaryen-a816627051c67ae14f6defc8fc5c616ba427a29e.zip | |
[J2Cl] Make J2clOpts more effective with transitive deps in constant intialization (#6571)
Constants that need to be hoisted sometimes are initialized by calling
getters of other constants that need to be hoisted. These getters are
non-trivial, e.g.
(func $getConst1_<once>_@X (result (ref null $A))
(block (result (ref null $A))
(if (i32.eqz (ref.is_null (global.get $$const1@X)))
(then
(return (global.get $$const1@X))
)
)
(global.set $$const1@X (struct.new $A (i32.const 2)))
(global.get $$const1@X)
)
(func $getConst2_<once>_@X (result (ref null $A))
(block (result (ref null $A))
(if (i32.eqz (ref.is_null (global.get $$const2@X)))
(then
(return (global.get $$const2@X))
)
)
(global.set $$const2@X .... expression with (call $getConst1_<once>_@X) ....))
(global.get $$const2@X)
)
and can only be simplified after the constants they initialize are hoisted. After
the constant is hoisted the getter can be inlined and constants that depend on
it for their initialization can now be hoisted.
Before this pass, inlining would happen after the pass was run by a subsequent
run of the inliner (likely as part of -O3), requiring as many runs of this pass,
interleaved with the inliner, as the depth in the call sequence.
By having a simpler inliner run as part of the loop in this pass, the pass becomes
more effective and more independent of the call depths.
Diffstat (limited to 'test/lit/passes/j2cl-inline.wast')
| -rw-r--r-- | test/lit/passes/j2cl-inline.wast | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/lit/passes/j2cl-inline.wast b/test/lit/passes/j2cl-inline.wast index 9b6d4127b..9148b5378 100644 --- a/test/lit/passes/j2cl-inline.wast +++ b/test/lit/passes/j2cl-inline.wast @@ -1,8 +1,6 @@ ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited. -;; NOTE: In real world example no-inline would use _<once>_ but there is escaping problem in a multi-platform -;; way in lit so we are working around it by using no-inline with a different pattern that matches same method. -;; RUN: foreach %s %t wasm-opt --no-inline=*clinit* --optimize-j2cl --inlining --vacuum --optimize-level=3 -all -S -o - | filecheck %s +;; RUN: foreach %s %t wasm-opt --optimize-j2cl --vacuum -all -S -o - | filecheck %s ;; Only trivial once functions are inlined (module |