diff options
| author | Alon Zakai <azakai@google.com> | 2023-01-06 09:46:59 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-06 09:46:59 -0800 |
| commit | 73a1cfcacd028ed7aefe304c2e140cda4068dcb0 (patch) | |
| tree | fdeefcc7e054af52546609bcdcf2b5874c4ee492 /test/lit/passes/optimize-instructions-gc.wast | |
| parent | ad38ddefb3728aaef0df69bd265412a38bcfd20d (diff) | |
| download | binaryen-73a1cfcacd028ed7aefe304c2e140cda4068dcb0.tar.gz binaryen-73a1cfcacd028ed7aefe304c2e140cda4068dcb0.tar.bz2 binaryen-73a1cfcacd028ed7aefe304c2e140cda4068dcb0.zip | |
[Wasm GC] Fix optimizations on ref.cast of null, and optimize to ref.as_non_null (#5398)
We were checking the heap type, but now casts care about the nullability as
well.
If the nullability is the only problem, that is, the heap type will be fine but we
might have a null, we can at least switch a ref.cast (non-null) to a
ref.as_non_null.
Diffstat (limited to 'test/lit/passes/optimize-instructions-gc.wast')
| -rw-r--r-- | test/lit/passes/optimize-instructions-gc.wast | 63 |
1 files changed, 63 insertions, 0 deletions
diff --git a/test/lit/passes/optimize-instructions-gc.wast b/test/lit/passes/optimize-instructions-gc.wast index 9ca0c81e0..04ae7a5cc 100644 --- a/test/lit/passes/optimize-instructions-gc.wast +++ b/test/lit/passes/optimize-instructions-gc.wast @@ -3120,4 +3120,67 @@ (ref.null nofunc) ) ) + + ;; CHECK: (func $ref-cast-heap-type (type $ref?|$B|_ref|$B|_=>_none) (param $null-b (ref null $B)) (param $b (ref $B)) + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (local.get $b) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (ref.as_non_null + ;; CHECK-NEXT: (local.get $null-b) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (local.get $b) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (local.get $null-b) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + ;; NOMNL: (func $ref-cast-heap-type (type $ref?|$B|_ref|$B|_=>_none) (param $null-b (ref null $B)) (param $b (ref $B)) + ;; NOMNL-NEXT: (drop + ;; NOMNL-NEXT: (local.get $b) + ;; NOMNL-NEXT: ) + ;; NOMNL-NEXT: (drop + ;; NOMNL-NEXT: (ref.as_non_null + ;; NOMNL-NEXT: (local.get $null-b) + ;; NOMNL-NEXT: ) + ;; NOMNL-NEXT: ) + ;; NOMNL-NEXT: (drop + ;; NOMNL-NEXT: (local.get $b) + ;; NOMNL-NEXT: ) + ;; NOMNL-NEXT: (drop + ;; NOMNL-NEXT: (local.get $null-b) + ;; NOMNL-NEXT: ) + ;; NOMNL-NEXT: ) + (func $ref-cast-heap-type (param $null-b (ref null $B)) (param $b (ref $B)) + ;; We are casting a heap type to a supertype, which always succeeds. However + ;; we need to check for nullability. + + ;; Non-nullable casts. When the input is non-nullable we must succeed. + (drop + (ref.cast $A + (local.get $b) + ) + ) + ;; When the input can be null, we might fail if it is a null. But we can + ;; switch to checking only that. + (drop + (ref.cast $A + (local.get $null-b) + ) + ) + + ;; Null casts. Both of these must succeed. + (drop + (ref.cast null $A + (local.get $b) + ) + ) + (drop + (ref.cast null $A + (local.get $null-b) + ) + ) + ) ) |