diff options
| author | Thomas Lively <tlively@google.com> | 2023-08-17 13:57:23 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-17 13:57:23 -0700 |
| commit | 67dd6f7db409f9ab7171e97db9da2a4e01a5dc4b (patch) | |
| tree | c063c06898fa1430c38715b5b05ed0cfec036f37 /test/lit/passes/remove-unused-brs-gc.wast | |
| parent | c39ca2e1cde95b6fcef6cdfeb9326dadd75e55df (diff) | |
| download | binaryen-67dd6f7db409f9ab7171e97db9da2a4e01a5dc4b.tar.gz binaryen-67dd6f7db409f9ab7171e97db9da2a4e01a5dc4b.tar.bz2 binaryen-67dd6f7db409f9ab7171e97db9da2a4e01a5dc4b.zip | |
Ensure br_on_cast* target type is subtype of input type (#5881)
The WasmGC spec will require that the target cast type of br_on_cast and
br_on_cast_fail be a subtype of the input type, but so far Binaryen has not
enforced this constraint, so it could produce invalid modules when optimizations
refined the input to a br_on_cast* such that it was no longer a supertype of the
cast target type.
Fix this problem by setting the cast target type to be the greatest lower bound
of the original cast target type and the current input type in
`BrOn::finalize()`. This maintains the invariant that the cast target type
should be a subtype of the input type and it also does not change cast behavior;
any value that could make the original cast succeed at runtime necessarily
inhabits both the original cast target type and the input type, so it also must
inhabit their greatest lower bound and will make the updated cast succeed as
well.
Diffstat (limited to 'test/lit/passes/remove-unused-brs-gc.wast')
| -rw-r--r-- | test/lit/passes/remove-unused-brs-gc.wast | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/lit/passes/remove-unused-brs-gc.wast b/test/lit/passes/remove-unused-brs-gc.wast index 50ffd9583..94dbabc6b 100644 --- a/test/lit/passes/remove-unused-brs-gc.wast +++ b/test/lit/passes/remove-unused-brs-gc.wast @@ -95,7 +95,7 @@ ;; CHECK: (func $br_on_cast_unrelated (type $none_=>_ref?|$struct|) (result (ref null $struct)) ;; CHECK-NEXT: (local $nullable-struct2 (ref null $struct2)) - ;; CHECK-NEXT: (block $block (result (ref null $struct)) + ;; CHECK-NEXT: (block $block (result nullref) ;; CHECK-NEXT: (drop ;; CHECK-NEXT: (struct.new_default $struct2) ;; CHECK-NEXT: ) @@ -106,7 +106,7 @@ ;; CHECK-NEXT: (local.get $nullable-struct2) ;; CHECK-NEXT: ) ;; CHECK-NEXT: (drop - ;; CHECK-NEXT: (br_on_cast $block (ref null $struct2) (ref null $struct) + ;; CHECK-NEXT: (br_on_cast $block (ref null $struct2) nullref ;; CHECK-NEXT: (local.get $nullable-struct2) ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) @@ -165,7 +165,7 @@ ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) ;; CHECK-NEXT: (drop - ;; CHECK-NEXT: (br_on_cast_fail $block (ref null $struct2) (ref null $struct) + ;; CHECK-NEXT: (br_on_cast_fail $block (ref null $struct2) nullref ;; CHECK-NEXT: (local.get $nullable-struct2) ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) |