diff options
| author | Thomas Lively <tlively@google.com> | 2024-03-22 16:56:33 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-22 23:56:33 +0000 |
| commit | b3fea30f84fef3ff7aa77775e00b83ba62d997cc (patch) | |
| tree | 53494a466d8e56d34d849d14927817a22f843748 /test/lit/strings.wast | |
| parent | d3414c3deaebe7ba35731a8c20d7fa5f5a833ca3 (diff) | |
| download | binaryen-b3fea30f84fef3ff7aa77775e00b83ba62d997cc.tar.gz binaryen-b3fea30f84fef3ff7aa77775e00b83ba62d997cc.tar.bz2 binaryen-b3fea30f84fef3ff7aa77775e00b83ba62d997cc.zip | |
[Strings] Represent string values as WTF-16 internally (#6418)
WTF-16, i.e. arbitrary sequences of 16-bit values, is the encoding of Java and
JavaScript strings, and using the same encoding makes the interpretation of
string operations trivial, even when accounting for non-ascii characters.
Specifically, use little-endian WTF-16.
Re-encode string constants from WTF-8 to WTF-16 in the parsers, then back to
WTF-8 in the writers. Update the constructor for string `Literal`s to interpret
the string as WTF-16 and store a sequence of WTF-16 code units, i.e. 16-bit
integers. Update `Builder::makeConstantExpression` accordingly to convert from
the new `Literal` string representation back to a WTF-16 string.
Update the interpreter to remove the logic for detecting non-ascii characters
and bailing out. The naive implementations of all the string operations are
correct now that our string encoding matches the JS string encoding.
Diffstat (limited to 'test/lit/strings.wast')
| -rw-r--r-- | test/lit/strings.wast | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/lit/strings.wast b/test/lit/strings.wast index b7cf0bf63..1166f13d0 100644 --- a/test/lit/strings.wast +++ b/test/lit/strings.wast @@ -41,8 +41,8 @@ ;; CHECK: (type $12 (func (param stringref) (result i32))) - ;; CHECK: (global $string-const stringref (string.const "string in a global \01\ff\00\t\t\n\n\r\r\"\"\'\'\\\\")) - (global $string-const stringref (string.const "string in a global \01\ff\00\t\09\n\0a\r\0d\"\22\'\27\\\5c")) + ;; CHECK: (global $string-const stringref (string.const "string in a global \c2\a3_\e2\82\ac_\f0\90\8d\88 \01\00\t\t\n\n\r\r\"\"\'\'\\\\ ")) + (global $string-const stringref (string.const "string in a global \C2\A3_\E2\82\AC_\F0\90\8D\88 \01\00\t\t\n\n\r\r\"\"\'\'\\\\ ")) ;; CHECK: (memory $0 10 10) |