diff options
| author | Thomas Lively <tlively@google.com> | 2024-07-16 19:19:34 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-16 16:19:34 -0700 |
| commit | 6d2bef3ff80bb96455207852d506c5bf12a6a851 (patch) | |
| tree | ca7b4c0743a72083ce1fc15b6c0cdf44c8cd9b5c /test/lit/validation | |
| parent | d91f1c4ea8d4d8fc075fc868d6f7c05829003968 (diff) | |
| download | binaryen-6d2bef3ff80bb96455207852d506c5bf12a6a851.tar.gz binaryen-6d2bef3ff80bb96455207852d506c5bf12a6a851.tar.bz2 binaryen-6d2bef3ff80bb96455207852d506c5bf12a6a851.zip | |
[threads] Validate all features required by ref.null (#6757)
`ref.null` of shared types should only be allowed when shared-everything
is enabled, but we were previously checking only that reference types
were enabled when validating `ref.null`. Update the code to check all
features required by the null type and factor out shared logic for
printing lists of missing feature options in error messages.
Diffstat (limited to 'test/lit/validation')
| -rw-r--r-- | test/lit/validation/shared-absheaptype.wast | 2 | ||||
| -rw-r--r-- | test/lit/validation/shared-null.wast | 12 |
2 files changed, 13 insertions, 1 deletions
diff --git a/test/lit/validation/shared-absheaptype.wast b/test/lit/validation/shared-absheaptype.wast index 6ab3c0219..4426f31b3 100644 --- a/test/lit/validation/shared-absheaptype.wast +++ b/test/lit/validation/shared-absheaptype.wast @@ -1,4 +1,4 @@ -;; Test that shared structs require shared-everything threads +;; Test that shared basic heap types require shared-everything threads ;; RUN: not wasm-opt %s 2>&1 | filecheck %s --check-prefix NO-SHARED ;; RUN: wasm-opt %s --enable-reference-types --enable-gc --enable-shared-everything -o - -S | filecheck %s --check-prefix SHARED diff --git a/test/lit/validation/shared-null.wast b/test/lit/validation/shared-null.wast new file mode 100644 index 000000000..1c34873bb --- /dev/null +++ b/test/lit/validation/shared-null.wast @@ -0,0 +1,12 @@ +;; Test that shared nulls require shared-everything threads + +;; RUN: not wasm-opt %s 2>&1 | filecheck %s --check-prefix NO-SHARED +;; RUN: wasm-opt %s --enable-reference-types --enable-gc --enable-shared-everything -o - -S | filecheck %s --check-prefix SHARED + +;; NO-SHARED: ref.null requires additional features +;; NO-SHARED: [--enable-reference-types --enable-shared-everything] +;; SHARED: (ref.null (shared none)) + +(module + (func (drop (ref.null (shared none)))) +) |