diff options
| author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2021-05-18 15:58:31 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-18 15:58:31 -0700 |
| commit | 92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b (patch) | |
| tree | 988bdc1753ba73f41b7c2c5613170fa638a1e5f9 /test/passes/emit-js-wrapper=a.js.txt | |
| parent | f8bb9c228446998882edea012bf9fa3004262504 (diff) | |
| download | binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.gz binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.bz2 binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.zip | |
Remove Type ordering (#3793)
As found in #3682, the current implementation of type ordering is not correct,
and although the immediate issue would be easy to fix, I don't think the current
intended comparison algorithm is correct in the first place. Rather than try to
switch to using a correct algorithm (which I am not sure I know how to
implement, although I have an idea) this PR removes Type ordering entirely. In
places that used Type ordering with std::set or std::map because they require
deterministic iteration order, this PR uses InsertOrdered{Set,Map} instead.
Diffstat (limited to 'test/passes/emit-js-wrapper=a.js.txt')
| -rw-r--r-- | test/passes/emit-js-wrapper=a.js.txt | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/passes/emit-js-wrapper=a.js.txt b/test/passes/emit-js-wrapper=a.js.txt index c772e840b..865f65828 100644 --- a/test/passes/emit-js-wrapper=a.js.txt +++ b/test/passes/emit-js-wrapper=a.js.txt @@ -1,11 +1,11 @@ (module - (type $i32_=>_none (func (param i32))) (type $i32_i32_=>_i32 (func (param i32 i32) (result i32))) - (type $i32_i32_i32_f32_f64_=>_none (func (param i32 i32 i32 f32 f64))) + (type $i32_=>_none (func (param i32))) (type $i32_i64_f32_f64_=>_none (func (param i32 i64 f32 f64))) (type $i32_f32_f64_=>_none (func (param i32 f32 f64))) - (type $i32_f32_f64_=>_i32 (func (param i32 f32 f64) (result i32))) (type $i32_f32_f64_=>_i64 (func (param i32 f32 f64) (result i64))) + (type $i32_i32_i32_f32_f64_=>_none (func (param i32 i32 i32 f32 f64))) + (type $i32_f32_f64_=>_i32 (func (param i32 f32 f64) (result i32))) (import "env" "setTempRet0" (func $setTempRet0 (param i32))) (memory $0 256 256) (export "add" (func $add)) |