RemoveUnusedBrs: Remove final block nops in all cases (#4954)

This fixes what looks like it might be a regression in #4943. It's not actually
an issue since it just affects wat files, but it did uncover an existing
inefficiency. The situation is this:

(block
  ..
  (br $somewhere)
  (nop)
)

Removing such a nop is always helpful, as the pass might see that that
br goes to where control flow is going anyhow, and the nop would
confuse it. We used to remove such nops only when the block had a name,
which is why wat testcases looks optimal, but we were actually doing the
less-efficient thing on real-world code. It was a minor inefficiency, though, as
the nop is quickly removed by later passes anyhow. Still, the fix is trivial (to
always remove such nops, regardless of a name on the block or not).

1 files changed, 0 insertions, 13 deletions

diff --git a/test/passes/remove-unused-brs_enable-multivalue.txt b/test/passes/remove-unused-brs_enable-multivalue.txt
index 8240bba22..d3180299c 100644
--- a/test/passes/remove-unused-brs_enable-multivalue.txt
+++ b/test/passes/remove-unused-brs_enable-multivalue.txt
@@ -23,7 +23,6 @@
     (drop
      (i32.const 0)
     )
-    (nop)
    )
   )
  )
@@ -46,7 +45,6 @@
      (drop
       (i32.const 0)
      )
-     (nop)
     )
    )
   )
@@ -58,7 +56,6 @@
      (drop
       (i32.const 0)
      )
-     (nop)
     )
    )
   )
@@ -140,7 +137,6 @@
       (drop
        (i32.const 1)
       )
-      (nop)
      )
     )
    )
@@ -152,7 +148,6 @@
      (drop
       (i32.const 2)
      )
-     (nop)
     )
    )
   )
@@ -231,7 +226,6 @@
      (drop
       (i32.const 0)
      )
-     (nop)
     )
    )
   )
@@ -385,7 +379,6 @@
       (drop
        (i32.const 1)
       )
-      (nop)
      )
     )
     (block $a20
@@ -393,7 +386,6 @@
       (drop
        (i32.const 2)
       )
-      (nop)
      )
     )
    )
@@ -526,7 +518,6 @@
     (block $out49
      (block
       (call $loops)
-      (nop)
      )
     )
     (br $in48)
@@ -997,7 +988,6 @@
      (br_if $shape$6$continue
       (local.get $0)
      )
-     (nop)
     )
    )
   )
@@ -1790,7 +1780,6 @@
     (drop
      (i32.const 0)
     )
-    (nop)
    )
   )
  )
@@ -2326,8 +2315,6 @@
      (i32.const 0)
      (block $label$3
       (block
-       (nop)
-       (nop)
       )
      )
      (return