diff options
author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2021-05-18 15:58:31 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-18 15:58:31 -0700 |
commit | 92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b (patch) | |
tree | 988bdc1753ba73f41b7c2c5613170fa638a1e5f9 /test/reference-types.wast.fromBinary | |
parent | f8bb9c228446998882edea012bf9fa3004262504 (diff) | |
download | binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.gz binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.tar.bz2 binaryen-92b0cbdd9e2747c5cf6ecc546718d0ec0b1bc64b.zip |
Remove Type ordering (#3793)
As found in #3682, the current implementation of type ordering is not correct,
and although the immediate issue would be easy to fix, I don't think the current
intended comparison algorithm is correct in the first place. Rather than try to
switch to using a correct algorithm (which I am not sure I know how to
implement, although I have an idea) this PR removes Type ordering entirely. In
places that used Type ordering with std::set or std::map because they require
deterministic iteration order, this PR uses InsertOrdered{Set,Map} instead.
Diffstat (limited to 'test/reference-types.wast.fromBinary')
-rw-r--r-- | test/reference-types.wast.fromBinary | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/reference-types.wast.fromBinary b/test/reference-types.wast.fromBinary index ee99c0d4e..00b621f44 100644 --- a/test/reference-types.wast.fromBinary +++ b/test/reference-types.wast.fromBinary @@ -3,8 +3,8 @@ (type $sig_anyref (func (param anyref))) (type $sig_funcref (func (param funcref))) (type $none_=>_funcref (func (result funcref))) - (type $none_=>_none (func)) (type $sig_externref (func (param externref))) + (type $none_=>_none (func)) (type $none_=>_externref (func (result externref))) (type $i32_=>_none (func (param i32))) (type $externref_=>_funcref (func (param externref) (result funcref))) |