diff options
| author | Thomas Lively <tlively@google.com> | 2022-12-09 17:56:10 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-09 23:56:10 +0000 |
| commit | 082dbe25b7377809b1b3dc429cb334fc80fac286 (patch) | |
| tree | 62478deb4383c8f78ca648fd6ea8629494a9a113 /test/spec/ref_cast.wast | |
| parent | 48959ab5a74d849e9782f54b3535c6fca69d51d7 (diff) | |
| download | binaryen-082dbe25b7377809b1b3dc429cb334fc80fac286.tar.gz binaryen-082dbe25b7377809b1b3dc429cb334fc80fac286.tar.bz2 binaryen-082dbe25b7377809b1b3dc429cb334fc80fac286.zip | |
Use non-nullable ref.cast for non-nullable input (#5335)
We switched from emitting the legacy `ref.cast_static` instruction to emitting
`ref.cast null` in #5331, but that wasn't quite correct. The legacy instruction
had polymorphic typing so that its output type was nullable if and only if its
input type was nullable. In contrast, `ref.cast null` always has a a nullable
output type.
Fix our output by instead emitting non-nullable `ref.cast` if the output should
be non-nullable. Parse `ref.cast` in binary and text forms as well. Since the IR
can only represent the legacy polymorphic semantics, disallow unsupported casts
from nullable to non-nullable references or vice versa for now.
Diffstat (limited to 'test/spec/ref_cast.wast')
| -rw-r--r-- | test/spec/ref_cast.wast | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/spec/ref_cast.wast b/test/spec/ref_cast.wast index 22859d167..658f20c23 100644 --- a/test/spec/ref_cast.wast +++ b/test/spec/ref_cast.wast @@ -76,7 +76,7 @@ (func (export "test-ref-cast-struct") (drop - (ref.cast null struct (struct.new $t0)) + (ref.cast struct (struct.new $t0)) ) ) |