diff options
| author | Thomas Lively <tlively@google.com> | 2024-04-15 14:02:24 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-15 14:02:24 -0700 |
| commit | b1245577ba92b77a97e266cf4c7f7cd15e6e7f28 (patch) | |
| tree | 333e17f651e6ed9d24fa13aa86f38fcc907541cf /test/spec | |
| parent | 8c834e8257b03ea87b639ddac9adefec64fcad00 (diff) | |
| download | binaryen-b1245577ba92b77a97e266cf4c7f7cd15e6e7f28.tar.gz binaryen-b1245577ba92b77a97e266cf4c7f7cd15e6e7f28.tar.bz2 binaryen-b1245577ba92b77a97e266cf4c7f7cd15e6e7f28.zip | |
[Strings] Add a string lowering pass using magic imports (#6497)
The latest idea for efficient string constants is to encode the constants in
the import names of their globals and implement fast paths in the engines for
materializing those constants at instantiation time without needing to parse
anything in JS. This strategy only works for valid strings (i.e. strings without
unpaired surrogates) because only valid strings can be used as import names in
the WebAssembly syntax.
Add a new configuration of the StringLowering pass that encodes valid string
contents in import names, falling back to the JSON custom section approach for
invalid strings.
To test this chang, update the printer to escape import and export names
properly and update the legacy parser to parse escapes in import and export
names properly. As a drive-by, remove the incorrect check in the parser that the
import module and base names are non-empty.
Diffstat (limited to 'test/spec')
| -rw-r--r-- | test/spec/import-after-memory.fail.wast | 1 | ||||
| -rw-r--r-- | test/spec/old_import.wast | 10 |
2 files changed, 0 insertions, 11 deletions
diff --git a/test/spec/import-after-memory.fail.wast b/test/spec/import-after-memory.fail.wast deleted file mode 100644 index fbe582a93..000000000 --- a/test/spec/import-after-memory.fail.wast +++ /dev/null @@ -1 +0,0 @@ -(module (memory 0) (import "" "" (global i32))) diff --git a/test/spec/old_import.wast b/test/spec/old_import.wast index eba633388..a68df1389 100644 --- a/test/spec/old_import.wast +++ b/test/spec/old_import.wast @@ -126,16 +126,6 @@ (assert_trap (invoke "call" (i32.const 3)) "uninitialized element") (assert_trap (invoke "call" (i32.const 100)) "undefined element") - -(assert_invalid - (module (import "" "" (table 10 funcref)) (import "" "" (table 10 funcref))) - "multiple tables" -) -(assert_invalid - (module (import "" "" (table 10 funcref)) (table 10 funcref)) - "multiple tables" -) - (assert_unlinkable (module (import "spectest" "unknown" (table 10 funcref))) "unknown import" |