diff options
| author | Sam Clegg <sbc@chromium.org> | 2019-12-06 14:56:07 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-06 14:56:07 -0600 |
| commit | b232033385b025ba276423613fb67f644c0596ce (patch) | |
| tree | b30376610ebafcf6e44d2becb7c8eebfe4b74e7f /test/unit/test_finalize.py | |
| parent | 6f55457c3edbeed202f27647a2cf0482160af098 (diff) | |
| download | binaryen-b232033385b025ba276423613fb67f644c0596ce.tar.gz binaryen-b232033385b025ba276423613fb67f644c0596ce.tar.bz2 binaryen-b232033385b025ba276423613fb67f644c0596ce.zip | |
Don't include `$` with names unless outputting to wat format (#2506)
The `$` is not actually part of the name, its the marker that starts
a name in the wat format. It can be confusing to see it show up when
doing `cerr << name`, for example.
This change has Print.cpp add the `$` which seem like the right place
to do this. Plus it revealed a bunch of places where were not calling
printName to escape all the names we were printing.
Diffstat (limited to 'test/unit/test_finalize.py')
| -rw-r--r-- | test/unit/test_finalize.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/unit/test_finalize.py b/test/unit/test_finalize.py index 14b752a87..9a5c3c750 100644 --- a/test/unit/test_finalize.py +++ b/test/unit/test_finalize.py @@ -11,5 +11,5 @@ class EmscriptenFinalizeTest(utils.BinaryenTestCase): os.path.join(input_dir, 'input', 'em_asm_mangled_string.wast'), '-o', os.devnull, '--global-base=1024' ], check=False, capture_output=True) self.assertNotEqual(p.returncode, 0) - self.assertIn('Fatal: local.get of unknown in arg0 of call to $emscripten_asm_const_int (used by EM_ASM* macros) in function $main.', p.stderr) + self.assertIn('Fatal: local.get of unknown in arg0 of call to emscripten_asm_const_int (used by EM_ASM* macros) in function main.', p.stderr) self.assertIn('This might be caused by aggressive compiler transformations. Consider using EM_JS instead.', p.stderr) |